Message-ID: <44dbf5e4-8eec-da56-daba-755128b3723e@pgmasters.net>
Date: Fri, 8 Jul 2022 08:20:09 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: remove more archiving overhead
Content-Language: en-US
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, nathandbossart@gmail.com
Cc: robertmhaas@gmail.com, masao.fujii@oss.nttdata.com,
 pgsql-hackers@postgresql.org
References: <20220707182251.GA2255242@nathanxps13>
 <ba7e11b0-054d-1d26-bafd-7a2bc97f11f7@pgmasters.net>
 <20220707220716.GA2258527@nathanxps13>
 <20220708.105652.1551158050191356887.horikyota.ntt@gmail.com>
From: David Steele <david@pgmasters.net>
In-Reply-To: <20220708.105652.1551158050191356887.horikyota.ntt@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/44dbf5e4-8eec-da56-daba-755128b3723e%40pgmasters.net>
Precedence: bulk

On 7/7/22 21:56, Kyotaro Horiguchi wrote:
> At Thu, 7 Jul 2022 15:07:16 -0700, Nathan Bossart <nathandbossart@gmail.com> wrote in
>> Here's an updated patch.
> 
> Thinking RFC'ish, the meaning of "may" and "must" is significant in
> this description.  On the other hand it uses both "may" and "can" but
> I thinkthat their difference is not significant or "can" there is
> somewhat confusing.  I think the "can" should be "may" here.

+1.

> And since "must" is emphasized, doesn't "may" also needs emphasis?

I think emphasis only on must is fine.

Nathan, I don't see the language about being sure to persist to storage 
here?

Regards,
-David