Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rzYgu-004rlr-1z
	for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Apr 2024 09:13:24 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rzYgq-00DGZ8-FQ
	for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Apr 2024 09:13:20 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <a.melnikov@postgrespro.ru>)
	id 1rzYgq-00DGZ0-26
	for pgsql-hackers@lists.postgresql.org; Wed, 24 Apr 2024 09:13:20 +0000
Received: from mail.postgrespro.ru ([93.174.131.139])
	by magus.postgresql.org with esmtps  (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <a.melnikov@postgrespro.ru>)
	id 1rzYgi-002g8V-M4
	for pgsql-hackers@postgresql.org; Wed, 24 Apr 2024 09:13:19 +0000
Received: from [172.30.1.222] (unknown [172.30.1.222])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(Client did not present a certificate)
	(Authenticated sender: a.melnikov@postgrespro.ru)
	by mail.postgrespro.ru (Postfix/587) with ESMTPSA id B0675E20E38;
	Wed, 24 Apr 2024 12:13:10 +0300 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru;
	s=mx2023; t=1713949990;
	bh=ue+JKpcNZIqyzdKkosppxl82CoiqD+/CTgrP1sd+S/I=;
	h=Message-ID:Date:User-Agent:Subject:To:References:From:In-Reply-To:
	 From;
	b=UhSfzi5hTcEFZtn51jVBnMTV2j7tebNr9ofrC24r2E34VR6Ap9VyZpd7zWyzjEK5l
	 ufEPsasJQ1qPZsii64xGPk8XlZgkmiHNNe5TOUEwWrgYjKg/AQ3gaBSa7M14yDiS96
	 gF+jjxqKivEtnIOdGjoBhpD9mtVHD7DtH4GjMV08K4e2MyJQVA8d1VLkaWbedf7SaL
	 m5dbCfQ0E1tz9Nr1Ulscitq0IKlu3KlEnRy2naAdPPi1D3LYP5r75cqzux2WmxbNwO
	 vPahx6krZnBN3s4m61RTpnbfVPqzemSJRdzDvJiSPx9y4Un78zOoznTTlyO2XsSjWA
	 A/WveXPMjpwiA==
Message-ID: <44faf5a1-1e84-4ae5-9ea7-106af77cf96b@postgrespro.ru>
Date: Wed, 24 Apr 2024 12:13:10 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?
To: Peter Eisentraut <peter@eisentraut.org>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <0841ec77-47e5-452a-adb4-c6fa55d605fc@postgrespro.ru>
 <474746ef-fa9f-400e-902e-3bb018320ca0@eisentraut.org>
Content-Language: en-US
From: "Anton A. Melnikov" <a.melnikov@postgrespro.ru>
In-Reply-To: <474746ef-fa9f-400e-902e-3bb018320ca0@eisentraut.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/44faf5a1-1e84-4ae5-9ea7-106af77cf96b%40postgrespro.ru>
Precedence: bulk

On 24.04.2024 12:02, Peter Eisentraut wrote:
> On 19.04.24 05:50, Anton A. Melnikov wrote:
>>
>> May be better use this macro everywhere in C code?
> 
> I don't know.  I don't find XLOG_CONTROL_FILE to be a very intuitive proxy for "pg_control".
> 

Then maybe replace XLOG_CONTROL_FILE with PG_CONTROL_FILE?

The PG_CONTROL_FILE_SIZE macro is already in the code.
  
With the best regards,

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company