From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Jubilee Young <workingjubilee@gmail.com>,
        pgsql-hackers@lists.postgresql.org,
        John Naylor <johncnaylorls@gmail.com>
Subject: Re: Hide exposed impl detail of wchar.c
In-reply-to: <20231116225402.GA2882846@nathanxps13>
References: <CAPNHn3oKJJxMsYq+qLYzVJOFrUcOr4OF1EC-KtFT-qh8nOOOtQ@mail.gmail.com> <20231116225402.GA2882846@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Thu, 16 Nov 2023 16:54:02 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <450043.1700175990.1@sss.pgh.pa.us>
Date: Thu, 16 Nov 2023 18:06:30 -0500
Message-ID: <450044.1700175990@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/450044.1700175990%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> It looks like is_valid_ascii() was originally added to pg_wchar.h so that
> it could easily be used elsewhere [0] [1], but that doesn't seem to have
> happened yet.

It seems to be new as of v15, so there wouldn't have been a lot of time
for external code to adopt it.  As far as I can tell from Debian Code
Search, nobody has yet.

> Would moving this definition to a separate header file be a viable option?
> That'd still break any existing projects that are using it, but at least
> there'd be an easy fix.

That would provide a little bit of cover, at least, compared to just
hiding it in the .c file.

I'm generally sympathetic to the idea that simd.h was a rather large
dependency to add to something as widely used as pg_wchar.h.  So I'd
favor getting it out of there just on compilation-time grounds,
independently of whether it's causing active problems.  That argument
wouldn't justify a back-patch, but "it's causing problems" might.

			regards, tom lane