From: Nikolay Shaplov <dhyan@nataraj.su>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
 Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Dent John <denty@qqdd.eu>, "Iwata, Aya" <iwata.aya@jp.fujitsu.com>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 Dmitry Dolgov <9erthalion6@gmail.com>, Thomas Munro <thomas.munro@gmail.com>
Subject: Re: [PATCH] Add some useful asserts into View Options macroses
Date: Tue, 08 Oct 2019 13:44:25 +0300
Message-ID: <4501528.Pae3bDk7cQ@x200m>
User-Agent: KMail/5.2.3 (Linux/4.9.0-8-amd64; KDE/5.28.0; x86_64; ; )
In-Reply-To: 
 <CA+TgmobsfF_Rr89TS-2zDVTLjbp84WLJg4-reuqvN7yNHFMg6Q@mail.gmail.com>
References: <3634983.eHpMQ1mJnI@x200m>
 <CA+TgmobsfF_Rr89TS-2zDVTLjbp84WLJg4-reuqvN7yNHFMg6Q@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

=D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 =D0=BF=D0=BE=D0=BD=
=D0=B5=D0=B4=D0=B5=D0=BB=D1=8C=D0=BD=D0=B8=D0=BA, 7 =D0=BE=D0=BA=D1=82=D1=
=8F=D0=B1=D1=80=D1=8F 2019 =D0=B3. 12:59:27 MSK =D0=BF=D0=BE=D0=BB=D1=8C=D0=
=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C Robert=20
Haas =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:

> > This thread is a follow up to the thread
> > https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m where I'=
ve
> > been trying to remove StdRdOptions structure and replace it with unique
> > structure for each relation kind.
> >=20
> > I've decided to split that patch into smaller parts.
> >=20
> > This part adds some asserts to ViewOptions macroses.
> > Since an option pointer there is converted into (ViewOptions *) it would
> > be
> > really good to make sure that this macros is called in proper context, =
and
> > we do the convertation properly. At least when running tests with asser=
ts
> > turned on.
> Seems like a good idea.  Should we try to do something similar for the
> macros in that header file that cast to StdRdOptions?

That would not be as easy as for ViewOptions. For example as for the curren=
t=20
master code, fillfactor from StdRdOptions is used in Toast, Heap, Hash inde=
x,=20
nbtree index, and spgist index. This will make RelationGetFillFactor macros=
 a=20
bit complicated for example.

Now I have patches that limits usage of StdRdOptions to Heap and Toast.

When StdRdOptions is not that widely used, we whould be able to add asserts=
=20
for it, it will not make the code too complex.

So I would suggest to do ViewOptions asserts now, and keep dealing with=20
StdRdOptions for later. When we are finished with my current patches, I wil=
l=20
take care about it.

=2D-=20
Software Developer: https://www.upwork.com/freelancers/~014a87e140ff02c0da
Body-oriented Therapist: https://vk.com/nataraj_rebalancing  (Russian)