Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMyGa-0006AD-3t for pgsql-hackers@arkaria.postgresql.org; Sat, 13 Aug 2022 21:01:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oMyGY-00042M-SQ for pgsql-hackers@arkaria.postgresql.org; Sat, 13 Aug 2022 21:01:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMyGY-00042C-J4 for pgsql-hackers@lists.postgresql.org; Sat, 13 Aug 2022 21:01:54 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMyGU-0001l5-2K for pgsql-hackers@lists.postgresql.org; Sat, 13 Aug 2022 21:01:54 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 27DL1lti450837; Sat, 13 Aug 2022 17:01:47 -0400 From: Tom Lane To: Zhang Mingli cc: PostgreSQL Hackers Subject: Re: [patch]HashJoin crash In-reply-to: References: <9746d4e1-a008-44a3-bce9-170b4721e862@Spark> Comments: In-reply-to Zhang Mingli message dated "Fri, 12 Aug 2022 23:05:06 +0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <450835.1660424507.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 13 Aug 2022 17:01:47 -0400 Message-ID: <450836.1660424507@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Zhang Mingli writes: > In ExecChooseHashTableSize(), commit b154ee63bb uses func pg_nextpower2_= size_t > whose param must not be 0. Right. Fix pushed, thanks. regards, tom lane