From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Jeevan Chalke <jeevan.chalke@enterprisedb.com>,
        Peter Eisentraut <peter@eisentraut.org>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: More new SQL/JSON item methods
In-reply-to: <448055.1706214831@sss.pgh.pa.us>
References: 
 <CAM2+6=XjTyqrrqHAOj80r0wVQxJSxc0iyib9bPC55uFO9VKatg@mail.gmail.com>
 <CAM2+6=UCSp74devvHYpMx5NvpyWbCO3gYvgpEYHtNYqF2j6Z9Q@mail.gmail.com>
 <c3158517-940d-278e-d9ea-846c65430a14@dunslane.net>
 <CAM2+6=UrDfcsz0xn+oUmomOnPYazuP8dAM_Wrx5YMsWxXjWyKA@mail.gmail.com>
 <d37da0bc-204a-125a-dfeb-c3d7cc639d69@dunslane.net>
 <CAM2+6=UMCtXVSk1NmGHzsYYY6xGdnaMMKxVaKUtG7o0jkiuyQg@mail.gmail.com>
 <e913dde5-0209-441c-8040-dd2ace6415e0@eisentraut.org>
 <fa454906-7539-4070-b51a-2e7dcfb6b741@eisentraut.org>
 <CAM2+6=XPHNJnGypXy2C_5TUWgCxCktz1GrwuzsSZSqb_R+pMXQ@mail.gmail.com>
 <CAM2+6=WYbL4gxpmEJcN5BvLYuMZUpruLQRZxFeKTBNNpksgN=g@mail.gmail.com>
 <cc883de1-ae89-438b-a97e-926ad332f5ba@eisentraut.org>
 <CAM2+6=WyoinYoiuf3msxqH-hsPBoUz33MmrCpD_4Ceo6Nq1qOg@mail.gmail.com>
 <1d092c02-8249-4e56-8b8e-ae4db95b8fde@eisentraut.org>
 <CAM2+6=Wys-tgwA15WkgW+8uR0SKncFLZuj0B+ukjvxbrebz9qQ@mail.gmail.com>
 <5d37428e-0753-e721-8e77-81cc4d0dc9f1@dunslane.net>
 <439811.1706211069@sss.pgh.pa.us> <d42146aa-1a03-70ec!
 -72be-d368de2a4ba1@dunslane.net> <448055.1706214831@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Thu, 25 Jan 2024 15:33:51 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <451194.1706216300.1@sss.pgh.pa.us>
Date: Thu, 25 Jan 2024 15:58:20 -0500
Message-ID: <451195.1706216300@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/451195.1706216300%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> There's something else going on, because I'm still getting the
> assertion failure on my Mac with this fix in place.  Annoyingly,
> it goes away if I compile with -O0, so it's kind of hard to
> identify what's going wrong.

No, belay that: I must've got confused about which version I was
testing.  It's very unclear to me why the undefined reference
causes the preceding Assert to misbehave, but that is clearly
what's happening.  Compiler bug maybe?  My Mac has clang 15.0.0,
and the unhappy buildfarm members are also late-model clang.

Anyway, I did note that the preceding line

	res = jperOk;

is dead code and might as well get removed while you're at it.

			regards, tom lane