From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: Paul Jungwirth <pj@illuminatedcomputing.com>,
        Aleksander Alekseev <aleksander@timescale.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: format_datum debugging function
In-reply-to: <4f87171d-1623-4acf-8d7e-80a714ae68ea@eisentraut.org>
References: <286814e4-46d4-44d6-be45-c2ee979021e1@illuminatedcomputing.com> <CAJ7c6TO9CiAoGHYK=SMCTrXyoYAn4U=7c35QBgWwF9=H-3Bp=w@mail.gmail.com> <463c034f-a1bb-4361-ada7-83e994d86bfb@illuminatedcomputing.com> <fc8f0161-4ebe-4f70-8d25-be189bbf6e1f@eisentraut.org> <991fd3e7-f414-4320-8674-e9651ece1b4e@illuminatedcomputing.com> <4f87171d-1623-4acf-8d7e-80a714ae68ea@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Thu, 15 Aug 2024 09:50:15 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <451802.1723730707.1@sss.pgh.pa.us>
Date: Thu, 15 Aug 2024 10:05:07 -0400
Message-ID: <451803.1723730707@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/451803.1723730707%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> On 14.08.24 17:46, Paul Jungwirth wrote:
>> Are you doing something to get macro expansion? I've never gotten my gdb 
>> to see #defines, although in theory this configure line should do it, 
>> right?:

> Oh I see, you don't have the F_* constants available then.  Maybe just 
> put in the OID manually then?

That's pretty illegible and error-prone.  I agree that writing the
output function's C name is noticeably better.  However, I would
call the result DirectOutputFunctionCall and put it near
OidOutputFunctionCall in fmgr.c.  It's not like we don't already
have a naming convention and many instances of this.

(Also, now that I look at the code, I wonder why it looks so
little like any of the existing DirectFunctionCall functions.)

			regards, tom lane