Message-ID: <451F2552.7000308@commandprompt.com>
Date: Sat, 30 Sep 2006 19:17:54 -0700
From: "Joshua D. Drake" <jd@commandprompt.com>
Organization: Command Prompt, Inc.
User-Agent: Thunderbird 1.5.0.7 (X11/20060918)
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: Alvaro Herrera <alvherre@commandprompt.com>,
	Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: libedit broke in head
References: <451EB194.9090506@commandprompt.com>
	<15712.1159642857@sss.pgh.pa.us>
	<451EC216.8060104@kaltenbrunner.cc>
	<20060930200255.GC20466@alvh.no-ip.org>
	<16636.1159648616@sss.pgh.pa.us>
In-Reply-To: <16636.1159648616@sss.pgh.pa.us>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
>> I think the switches are confusing ... when you are using libedit, you
>> certainly don't want readline as well, so it seems natural to disable
>> it.  I understand that what --without-readline really does is turn the
>> line-editing capability off in general rather than just readline, which
>> is confusing.

Just to verify. With removing the second switch, were good. It tested
and ran clean.

> 
> The documentation could be improved perhaps:
> 
> $ ./configure --help | grep -i edit    
>   --with-libedit-preferred  prefer BSD Libedit over GNU Readline
>   --without-readline      do not use GNU Readline / BSD Libedit line editing
> $
> 
> ISTM the second line would be clearer if it read
> 
>   --without-readline      do not use GNU Readline nor BSD Libedit for editing
> 
> Also, we probably ought to see if we can make the libedit-preferred line
> come out second.

I really don't get the libedit-preferred syntax? Why not just:

--with-libedit 	use BSD Libedit not GNU Readline
--with-readline use GNU Readline not BSD Libedit
--without-readline do not use GNU Readline nor BSD Libedit

Of course --without-readline is really a misnomer too. But
--without-edit doesn't sound right.

Sincerely,

Joshua D. Drake


> 
> 			regards, tom lane
> 


-- 

   === The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
   Providing the most comprehensive  PostgreSQL solutions since 1997
             http://www.commandprompt.com/