Subject: Re: psql - add SHOW_ALL_RESULTS option
To: Fabien COELHO <coelho@cri.ensmp.fr>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
 "Bossart, Nathan" <bossartn@amazon.com>, Julien Rouhaud
 <rjuju123@gmail.com>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: <69C0B369-570C-4524-8EE4-BCCACECB6BEE@amazon.com>
 <20210412193301.GA11204@alvherre.pgsql> <YHeVHH0wVcRwdogL@paquier.xyz>
 <3738387.1618451507@sss.pgh.pa.us>
 <alpine.DEB.2.22.394.2104151336060.191178@pseudo>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <451a2111-3757-c511-9413-8f8af531a167@enterprisedb.com>
Date: Thu, 15 Apr 2021 20:06:59 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2104151336060.191178@pseudo>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/451a2111-3757-c511-9413-8f8af531a167%40enterprisedb.com>
Precedence: bulk

On 15.04.21 13:51, Fabien COELHO wrote:
>>> That's a lot IMO, so my vote would be to discard this feature for now
>>> and revisit it properly in the 15 dev cycle, so as resources are
>>> redirected into more urgent issues (13 open items as of the moment of
>>> writing this email).
>>
>> I don't wish to tell people which open issues they ought to work on
>> ... but this patch seems like it could be quite a large can of worms,
>> and I'm not detecting very much urgency about getting it fixed.
>> If it's not to be reverted then some significant effort needs to be
>> put into it soon.
> 
> My overly naive trust in non regression test to catch any issues has 
> been largely proven wrong. Three key features do not have a single 
> tests. Sigh.
> 
> I'll have some time to look at it over next week-end, but not before.

I have reverted the patch and moved the commit fest entry to CF 2021-07.