Message-ID: <451b0797-83b8-cdbc-727f-8d7a7b0e3bca@gmail.com>
Date: Sun, 18 Aug 2024 11:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: Refactoring postmaster's code to cleanup after child exit
Content-Language: en-US
To: Heikki Linnakangas <hlinnaka@iki.fi>,
 Thomas Munro <thomas.munro@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <835232c0-a5f7-4f20-b95b-5b56ba57d741@iki.fi>
 <a77061d9-1a76-470c-b18c-4f238342d124@iki.fi>
 <8f2118b9-79e3-4af7-b2c9-bd5818193ca4@iki.fi>
 <CA+hUKGKWqSFoJXzRC9D0owFj1Xby0qvWr-k6p8z9gQzT7+nr7w@mail.gmail.com>
 <e9e58efa-a364-4f4f-b112-a11d62af952a@iki.fi>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <e9e58efa-a364-4f4f-b112-a11d62af952a@iki.fi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/451b0797-83b8-cdbc-727f-8d7a7b0e3bca%40gmail.com>
Precedence: bulk

Hello Heikki,

10.08.2024 00:13, Heikki Linnakangas wrote:
>
> Committed the patches up to and including this one, with tiny comment changes.

I've noticed that on the current HEAD server.log contains binary data
(an invalid process name) after a child crash. For example, while playing
with -ftapv, I've got:
SELECT to_date('2024 613566758 1', 'IYYY IW ID');
server closed the connection unexpectedly

grep -a 'was terminated' server.log
2024-08-18 07:07:06.482 UTC|||66c19d96.3482f6|LOG:  `�!x� (PID 3441407) was terminated by signal 6: Aborted

It looks like this was introduced by commit 28a520c0b (IIUC, namebuf in
CleanupBackend() may stay uninitialized in some code paths).

Best regards,
Alexander