Date: Tue, 24 Oct 2006 14:43:20 +0200
From: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
Subject: Re: [HACKERS] COPY does not work with regproc and aclitem
In-reply-to: <27990.1161634170@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@commandprompt.com>, pgsql-hackers@postgresql.org,
	pgsql-patches@postgresql.org
Message-id: <453E0A68.4070506@sun.com>
MIME-version: 1.0
Content-type: multipart/mixed; boundary="Boundary_(ID_RUBdKsbwh4feq8pTxq+lEw)"
References: <453D1B73.2050906@sun.com> <20061023200200.GD11409@alvh.no-ip.org>
	<27990.1161634170@sss.pgh.pa.us>
User-Agent: Mail/News 1.5 (X11/20051211)

This is a multi-part message in MIME format.

--Boundary_(ID_RUBdKsbwh4feq8pTxq+lEw)
Content-type: text/plain; format=flowed; charset=ISO-8859-15
Content-transfer-encoding: 7BIT

Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
>> Hmm, maybe it should be using regprocedure instead?
> 
> Not unless you want to break initdb.  The only reason regproc still
> exists, really, is to accommodate loading of pg_type during initdb.
> Guess what: we can't do type lookup at that point.
> 

I prepared patch which use oid output function instead regproc output. 
This change works only for COPY TO command. SELECT behavior is 
untouched. I extended copy regression test as well.

Please, look on it if it is acceptable fix.

	With regards Zdenek

--Boundary_(ID_RUBdKsbwh4feq8pTxq+lEw)
Content-type: text/x-patch; name=copy.patch
Content-transfer-encoding: 7BIT
Content-disposition: inline; filename=copy.patch

Index: src/backend/commands/copy.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/commands/copy.c,v
retrieving revision 1.271
diff -c -r1.271 copy.c
*** src/backend/commands/copy.c	31 Aug 2006 03:17:50 -0000	1.271
--- src/backend/commands/copy.c	24 Oct 2006 12:35:45 -0000
***************
*** 1309,1315 ****
  									&out_func_oid,
  									&isvarlena);
  		else
! 			getTypeOutputInfo(attr[attnum - 1]->atttypid,
  							  &out_func_oid,
  							  &isvarlena);
  		fmgr_info(out_func_oid, &cstate->out_functions[attnum - 1]);
--- 1309,1317 ----
  									&out_func_oid,
  									&isvarlena);
  		else
! 			/* For regproc datatype do not lookup proc name, use OID out function instead.
! 			   It avoids problem with COPY FROM. */ 
! 			getTypeOutputInfo(attr[attnum - 1]->atttypid == REGPROCOID? OIDOID : attr[attnum - 1]->atttypid,
  							  &out_func_oid,
  							  &isvarlena);
  		fmgr_info(out_func_oid, &cstate->out_functions[attnum - 1]);
Index: src/test/regress/input/copy.source
===================================================================
RCS file: /projects/cvsroot/pgsql/src/test/regress/input/copy.source,v
retrieving revision 1.14
diff -c -r1.14 copy.source
*** src/test/regress/input/copy.source	2 May 2006 11:28:56 -0000	1.14
--- src/test/regress/input/copy.source	24 Oct 2006 12:35:46 -0000
***************
*** 105,107 ****
--- 105,113 ----
  
  copy copytest3 to stdout csv header;
  
+ --- test correct handling regproc data type
+ CREATE TEMP TABLE test_regproc (like pg_aggregate);
+ COPY pg_catalog.pg_aggregate TO '@abs_builddir@/results/test_regproc.data';
+ COPY test_regproc FROM '@abs_builddir@/results/test_regproc.data';
+ 
+ select aggfnoid, cast(aggfnoid as oid) from pg_aggregate where aggfnoid=2147;
Index: src/test/regress/output/copy.source
===================================================================
RCS file: /projects/cvsroot/pgsql/src/test/regress/output/copy.source,v
retrieving revision 1.12
diff -c -r1.12 copy.source
*** src/test/regress/output/copy.source	2 May 2006 11:28:56 -0000	1.12
--- src/test/regress/output/copy.source	24 Oct 2006 12:35:46 -0000
***************
*** 70,72 ****
--- 70,82 ----
  c1,"col with , comma","col with "" quote"
  1,a,1
  2,b,2
+ --- test correct handling regproc data type
+ CREATE TEMP TABLE test_regproc (like pg_aggregate);
+ COPY pg_catalog.pg_aggregate TO '@abs_builddir@/results/test_regproc.data';
+ COPY test_regproc FROM '@abs_builddir@/results/test_regproc.data';
+ select aggfnoid, cast(aggfnoid as oid) from pg_aggregate where aggfnoid=2147;
+      aggfnoid     | aggfnoid
+ ------------------+----------
+  pg_catalog.count |     2147
+ (1 row)
+ 

--Boundary_(ID_RUBdKsbwh4feq8pTxq+lEw)--