From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@postgresql.org, Heikki Linnakangas <hlinnaka@iki.fi>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: Re: WIP: Faster Expression Processing v4
In-reply-to: <20170315195838.2dqr2v674u4qwxw4@alap3.anarazel.de>
References: <20170307030137.lpo4japv5oqgbqpz@alap3.anarazel.de>
 <2090fd00-4dec-7b42-f700-64308958504c@2ndquadrant.com>
 <20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de>
 <fcdaa51b-e905-72e0-39dd-5e22f535a253@2ndquadrant.com>
 <20170314065259.ffef4tfhgbsaieoe@alap3.anarazel.de>
 <69b7bb0e-8dab-3d39-1a89-3c6ab6409f64@iki.fi>
 <20170314224706.nxvtapenky6eom3z@alap3.anarazel.de>
 <3086.1489606408@sss.pgh.pa.us>
 <855716B2-7522-4C79-A50E-2EB8E609764F@anarazel.de>
 <3401.1489606882@sss.pgh.pa.us>
 <20170315195838.2dqr2v674u4qwxw4@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 15 Mar 2017 12:58:38 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4541.1489608434.1@sss.pgh.pa.us>
Date: Wed, 15 Mar 2017 16:07:14 -0400
Message-ID: <4542.1489608434@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Andres Freund <andres@anarazel.de> writes:
> On 2017-03-15 15:41:22 -0400, Tom Lane wrote:
>> Color me dubious.  Which specific other places have you got in mind, and
>> do they have expression trees at hand that would tell them which columns
>> they really need to pull out?

> I was thinking of execGrouping.c's execTuplesMatch(),
> TupleHashTableHash() (and unequal, but doubt that matters
> performancewise).  There's also nodeHash.c's ExecHashGetValue(), but I
> think that'd possibly better fixed differently.

The execGrouping.c functions don't have access to an expression tree
instructing them which columns to pull out of the tuple, so I fail to see
how get_last_attnums() would be of any use to them.  As for
ExecHashGetHashValue, it's most likely going to be working from virtual
tuples passed up to the join, which won't benefit from predetermination
of the last column to be accessed.  The tuple-deconstruction would have
happened while projecting in the scan node below.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers