Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1Vr7-0000WP-Fg for pgsql-hackers@arkaria.postgresql.org; Sun, 26 Dec 2021 15:54:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n1Vr5-0005vF-4t for pgsql-hackers@arkaria.postgresql.org; Sun, 26 Dec 2021 15:54:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1Vr2-0005v5-VB for pgsql-hackers@lists.postgresql.org; Sun, 26 Dec 2021 15:54:38 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1Vqy-00029M-Ll for pgsql-hackers@lists.postgresql.org; Sun, 26 Dec 2021 15:54:35 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 395BC5801C2; Sun, 26 Dec 2021 10:54:30 -0500 (EST) Received: from imap49 ([10.202.2.99]) by compute5.internal (MEProxy); Sun, 26 Dec 2021 10:54:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=4c9ZwTAQJkwAf4ct3fEM2aZpT+MZs23 OcJYIpPpGoV8=; b=pcEt6XAWsrIMM5TInnFzFcF1VG5Z6KD6fKEZ6Mz0FRgRQiq /9wFpO0v0uv2hf36TaTMNcethXiL9G3JhUja83s0WBCKG7l3YNe8A850AdxHOlur p5334pk5Rn6glGqZoOgzrSsIHumWiW85prnHKGpfSR94/OQ+xuNdEKlaAx4ShbuW EvnwDuIEIHevp6sRqti/+hKlcBWjj2+w6ACZbSbGkmaq4kD9yQ1KmIU2xexK/IIj 1sLCxQc23+Gi/RKQTDKBeuohxpdqZq67vbmiLWR885sFess1MrjB6NCk8fuBSrWz QdQb00EiENm/NHGp2BPy2GkgKXYivBD3H6ggwOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=4c9ZwT AQJkwAf4ct3fEM2aZpT+MZs23OcJYIpPpGoV8=; b=QfeNdxDtiWy14FZxurJsck WhcEv2BNL6AybNGTl22NQPt0ttsPpAKqO4uO4eZIlZRktrUIShA0H13wxcQnywma lJ7eCutyKuQjg1k8d/2Tu2BwR9Mbgn+QL6W41C0829ja5EVZPOJFrFZYRWoZx4XS HjuNvW7Nw7rkvZWb14JGlQWDTEaYKvwdPa0KFXprlbwyHmEvl4KI8jjOFbXo/ffo 7t14cEysfiv78S1z8BrbxXD6boG29qCDNFUyKupz+3KG9jl+dmXOw7o7pbN9JHsf xGetxVPhDQ+eg6Z14RSD6PYCnYJD3quRDww9Zs1GXkAwFGrWoY1vfPTVNf/HxlCw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddugedghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesrgdtreerreertdenucfhrhhomhepfdfguhhl vghrucfvrghvvghirhgrfdcuoegvuhhlvghrsegvuhhlvghrthhordgtohhmqeenucggtf frrghtthgvrhhnpeejtefhuedvgffftdetvedufedtjeeuffekleevkefhveekgeelfefh jeehtdejgeenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepvghulhgvrhesvghu lhgvrhhtohdrtghomh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 54C7EF60074; Sun, 26 Dec 2021 10:54:29 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4525-g8883000b21-fm-20211221.001-g8883000b Mime-Version: 1.0 Message-Id: <4571f556-0209-495a-8eed-89367ae09a2a@www.fastmail.com> In-Reply-To: References: <49ba49f1-8bdb-40b7-ae9e-f17d88b3afcd@www.fastmail.com> <6b6cf26d-bf74-4b39-bb07-c067e381d66d@www.fastmail.com> Date: Sun, 26 Dec 2021 12:54:07 -0300 From: "Euler Taveira" To: "Amit Kapila" , "Peter Smith" Cc: "Ajin Cherian" , "houzj.fnst@fujitsu.com" , "Greg Nancarrow" , "vignesh C" , "tanghy.fnst@fujitsu.com" , "Dilip Kumar" , "Rahila Syed" , "Peter Eisentraut" , =?UTF-8?Q?=C3=96nder_Kalac=C4=B1?= , japin , "Michael Paquier" , "David Steele" , "Craig Ringer" , "Amit Langote" , "PostgreSQL Hackers" Subject: Re: row filtering for logical replication Content-Type: multipart/alternative; boundary=267e58f11f244db98371092b7899b374 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --267e58f11f244db98371092b7899b374 Content-Type: text/plain On Sat, Dec 25, 2021, at 1:20 AM, Amit Kapila wrote: > On Fri, Dec 24, 2021 at 11:04 AM Peter Smith wrote: > > > > So, IMO the PG docs wording for this part should be relaxed a bit. > > > > e.g. > > BEFORE: > > + A nullable column in the WHERE clause could cause the > > + expression to evaluate to false; avoid using columns without not-null > > + constraints in the WHERE clause. > > AFTER: > > + A nullable column in the WHERE clause could cause the > > + expression to evaluate to false. To avoid unexpected results, any possible > > + null values should be accounted for. > > > > Your suggested wording sounds reasonable to me. Euler, others, any thoughts? +1. -- Euler Taveira EDB https://www.enterprisedb.com/ --267e58f11f244db98371092b7899b374 Content-Type: text/html Content-Transfer-Encoding: quoted-printable
On Sat, Dec 25,= 2021, at 1:20 AM, Amit Kapila wrote:
On Fri, Dec 24, 2021 at 11:04 AM Peter Smith = <smithpb2250@gmail.com&g= t; wrote:
>
> So, IMO the PG docs word= ing for this part should be relaxed a bit.
>
<= div>> e.g.
> BEFORE:
> +  = ; A nullable column in the <literal>WHERE</literal> clause c= ould cause the
> +   expression to evaluate t= o false; avoid using columns without not-null
> + =   constraints in the <literal>WHERE</literal> clause.
> AFTER:
> +   A nullable col= umn in the <literal>WHERE</literal> clause could cause the
> +   expression to evaluate to false. To avoi= d unexpected results, any possible
> +   null= values should be accounted for.
>

Your suggested wording sounds reasonable to me. Euler, others, = any thoughts?
+1.


--
Euler Taveira
EDB   https://www= .enterprisedb.com/

--267e58f11f244db98371092b7899b374--