Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8pDI-0003j9-QX for pgsql-hackers@arkaria.postgresql.org; Sun, 07 Feb 2021 18:55:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l8pDG-0005oU-Up for pgsql-hackers@arkaria.postgresql.org; Sun, 07 Feb 2021 18:55:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8pDG-0005oM-Nq for pgsql-hackers@lists.postgresql.org; Sun, 07 Feb 2021 18:55:14 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8pD9-0004Oa-0j for pgsql-hackers@lists.postgresql.org; Sun, 07 Feb 2021 18:55:13 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 117It0dV457959; Sun, 7 Feb 2021 13:55:00 -0500 From: Tom Lane To: "Tang, Haiying" cc: "pgsql-hackers@lists.postgresql.org" Subject: Re: Support tab completion for upper character inputs in psql In-reply-to: References: Comments: In-reply-to "Tang, Haiying" message dated "Sun, 07 Feb 2021 07:06:09 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <457957.1612724100.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 07 Feb 2021 13:55:00 -0500 Message-ID: <457958.1612724100@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk "Tang, Haiying" writes: > When using psql I found there's no tab completion for upper character in= puts. It's really inconvenient sometimes so I try to fix this problem in t= he attached patch. This looks like you're trying to force case-insensitive behavior whether that is appropriate or not. Does not sound like a good idea. regards, tom lane