Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jvh6f-0003y1-4F for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jul 2020 13:05:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jvh6e-0004Zo-39 for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jul 2020 13:05:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jvh6d-0004Zh-9z for pgsql-hackers@lists.postgresql.org; Wed, 15 Jul 2020 13:05:51 +0000 Received: from [64.147.123.35] (helo=wforward5-smtp.messagingengine.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jvh6a-0002k0-5E for pgsql-hackers@postgresql.org; Wed, 15 Jul 2020 13:05:50 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailforward.west.internal (Postfix) with ESMTP id C291EAA9; Wed, 15 Jul 2020 09:05:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 15 Jul 2020 09:05:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=wjgs7VofRv0m9iHWHJpZFn+SnFPfJUOmf02IxErEI RM=; b=GiERAeZKoqEnnPuJfgHR6bVfslfp4HU+6zUlgDscNy4iLxq7GSnN51PMB cJsDOFx5WHbPc7y6KXDCBGiEeD5EtjuyU5JILutbGrfAE9oRd+bd3kv3/bbN7nO/ TO/pvUcNAuGNOP4mqcYagIN4OhEyTrMiamnLLdM8U+kx8bfhEqdnt8+YCfp2YvB1 RNq5TEhOzpDrBlG0jPs6cfOuRdFMUoCNiXrdZdUtK8sTSQV3ANT7H9lGhnDc4U83 ADWu9Kuwdq7GOu2D4d6Yv0/fVIyu4wjSXl67RKeCu6QqmjwtNNEZajoe8sfboos3 cbau2WmTRp1Lmpnev6MkghRAzzweQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfedvgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuhffvfhhokffffgggjggtgfesthejredttdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsedvnhguqh hurggurhgrnhhtrdgtohhmqeenucggtffrrghtthgvrhhnpedtheefgfdvudffudefvdej fedukeegudevjeevhfduudekuefhvdevueejfedvteenucffohhmrghinhepvdhnughquh grughrrghnthdrtghomhenucfkphepleefrddvgeefrdduledurddvfeeknecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghish gvnhhtrhgruhhtsedvnhguqhhurggurhgrnhhtrdgtohhm X-ME-Proxy: Received: from april.pezone.net (p5df3bfee.dip0.t-ipconnect.de [93.243.191.238]) by mail.messagingengine.com (Postfix) with ESMTPA id B7B26328005A; Wed, 15 Jul 2020 09:05:34 -0400 (EDT) Subject: Re: some more pg_dump refactoring From: Peter Eisentraut To: Fabien COELHO References: <6594334b-40fd-14f1-6bc5-877afa3feed5@2ndquadrant.com> <458c97a0-1841-88c9-eddf-a45a8ba86811@2ndquadrant.com> <68f63a2e-3576-9b65-ffb3-1235d5bec28a@2ndquadrant.com> Cc: pgsql-hackers Organization: 2ndQuadrant Message-ID: <45809a47-3173-344c-93da-8490cd96ac38@2ndquadrant.com> Date: Wed, 15 Jul 2020 15:05:32 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <68f63a2e-3576-9b65-ffb3-1235d5bec28a@2ndquadrant.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 64.147.123.35 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-07-09 16:14, Peter Eisentraut wrote: > On 2020-07-08 06:42, Fabien COELHO wrote: >>> What do you think about this patch to reorganize the existing code from that >>> old commit? >> >> I think it is a definite further improvement. >> >> Patch applies cleanly, compiles, global & pg_dump tap test ok, looks ok to >> me. > > Thanks. I have committed that, and attached is my original patch > adjusted to this newer style. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services