Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vN0jo-008Zi3-01 for pgsql-hackers@arkaria.postgresql.org; Sun, 23 Nov 2025 03:26:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vN0jm-00DDTL-1z for pgsql-hackers@arkaria.postgresql.org; Sun, 23 Nov 2025 03:26:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vN0jm-00DDTD-13 for pgsql-hackers@lists.postgresql.org; Sun, 23 Nov 2025 03:26:06 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vN0jh-000zvh-18 for pgsql-hackers@lists.postgresql.org; Sun, 23 Nov 2025 03:26:06 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 5AN3PuGf458107; Sat, 22 Nov 2025 22:25:56 -0500 From: Tom Lane To: Thomas Munro cc: Peter Eisentraut , Kyotaro Horiguchi , pgsql-hackers@lists.postgresql.org Subject: Re: PRI?64 vs Visual Studio (2022) In-reply-to: References: <20250331.152829.1921392690375275165.horikyota.ntt@gmail.com> <001bdc3b-ef94-4f24-b017-ac8ff0a2ea55@eisentraut.org> Comments: In-reply-to Thomas Munro message dated "Sun, 23 Nov 2025 16:10:15 +1300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <458105.1763868356.1@sss.pgh.pa.us> Date: Sat, 22 Nov 2025 22:25:56 -0500 Message-ID: <458106.1763868356@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Thomas Munro writes: > That'd leave only Cygwin with HAVE BUGGY_STRTOF. Perhaps they have > fixed their implementation[1]? Here's an experimental patch to drop > all remnants, which could be used to find out. No Windows/Cygwin > here. Hmm, what if we just commit it anyway? If their strtof() is > still broken and someone out there is running the tests and sees this > test fail, why shouldn't they take that up with libc at this stage? Hmm, we could get rid of the whole resultmap mechanism ... regards, tom lane