MIME-Version: 1.0
Date: Mon, 08 Aug 2022 15:23:30 +0700
From: r.zharkov@postgrespro.ru
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, Michael Paquier
 <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Checking pgwin32_is_junction() errors
In-Reply-To: 
 <CA+hUKGK+V61MRXsjUEO5GnhmpveoL6v5Ud7by2DFwVTeZuUBeg@mail.gmail.com>
References: 
 <CA+hUKGLfOOeyZpm5ByVcAt7x5Pn-=xGRNCvgiUPVVzjFLtnY0w@mail.gmail.com>
 <YmEOJwmmKPugH41o@paquier.xyz>
 <CA+hUKG+ntyS1CDxf5z9qNS41uYasqCQf+o44X3ALD9XnUmmqRA@mail.gmail.com>
 <CA+hUKGL97TZhXcaey8Vm0uKt6CTzyXDDQEvffHh6ZkkmAXvjcQ@mail.gmail.com>
 <e516eed3-3555-cdad-663e-e59e4a2b0355@dunslane.net>
 <205d5e64-6e0a-dede-5128-a55b54f4356f@dunslane.net>
 <CA+hUKGKn7Krpdx1+Wy5jMzKBZBP7hUX8igyMYXRRrDiQy_rPZw@mail.gmail.com>
 <CA+hUKGKWR3=B_=qg_+bmX=pjtQ5Zk_3Agco7xg8GgpvZBafJ7w@mail.gmail.com>
 <CA+hUKGK+V61MRXsjUEO5GnhmpveoL6v5Ud7by2DFwVTeZuUBeg@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <4590c37927d7b8ee84f9855d83229018@postgrespro.ru>
Content-Type: multipart/mixed;
 boundary="=_efbcdb742a364ca6856da0b04a17f29c"
Archived-At: 
 <https://www.postgresql.org/message-id/4590c37927d7b8ee84f9855d83229018%40postgrespro.ru>
Precedence: bulk

--=_efbcdb742a364ca6856da0b04a17f29c
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

On 2022-08-06 08:02, Thomas Munro wrote:
> 
> Pushed.
> 
> Hmm, this stuff could *really* use a little test framework that's run
> by check-world, that exercises these various replacement operations.
> But I also suspect that problems in this area are likely to be due to
> concurrency.  It's hard to make a simple test that simulates the case
> where a file is unlinked between system calls within stat() and hits
> the STATUS_DELETE_PENDING case.  That check is code I cargo-culted in
> this patch.  So much of the stuff we've had in the tree relating to
> that area has been wrong in the past...

Hello, hackers!

initdb on my windows 10 system stopped working after the commit
c5cb8f3b: "Provide lstat() for Windows."
The error message is: creating directory C:/HOME/data ... initdb:
error: could not create directory "C:/HOME": File exists

"C:/HOME" is the junction point to the second volume on my hard drive -
"\??\Volume{GUID}\" which name pgreadlink() erroneously strips here:
https://github.com/postgres/postgres/blob/7e29a79a46d30dc236d097825ab849158929d977/src/port/dirmod.c#L357.
So initdb could not stat the file with name "Volume{GUID}", tried to
create it and failed.
With the attached patch initdb works fine again.

-- 
regards,

Roman
--=_efbcdb742a364ca6856da0b04a17f29c
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=dirmod.c.patch
Content-Disposition: attachment;
 filename=dirmod.c.patch;
 size=514

ZGlmZiAtLWdpdCBhL3NyYy9wb3J0L2Rpcm1vZC5jIGIvc3JjL3BvcnQvZGlybW9kLmMKaW5kZXgg
MjgxOGJmZDJlOTUuLjlkNzM2MjBhNmJhIDEwMDY0NAotLS0gYS9zcmMvcG9ydC9kaXJtb2QuYwor
KysgYi9zcmMvcG9ydC9kaXJtb2QuYwpAQCAtMzU0LDcgKzM1NCw4IEBAIHBncmVhZGxpbmsoY29u
c3QgY2hhciAqcGF0aCwgY2hhciAqYnVmLCBzaXplX3Qgc2l6ZSkKIAkgKiBJZiB0aGUgcGF0aCBz
dGFydHMgd2l0aCAiXD8/XCIsIHdoaWNoIGl0IHdpbGwgZG8gaW4gbW9zdCAoYWxsPykgY2FzZXMs
CiAJICogc3RyaXAgdGhvc2Ugb3V0LgogCSAqLwotCWlmIChyID4gNCAmJiBzdHJuY21wKGJ1Ziwg
IlxcPz9cXCIsIDQpID09IDApCisJaWYgKHIgPiA0ICYmIHN0cm5jbXAoYnVmLCAiXFw/P1xcIiwg
NCkgPT0gMCAmJgorCQlzdHJuY21wKGJ1ZiwgIlxcPz9cXFZvbHVtZSIsIDEwKSAhPSAwKQogCXsK
IAkJbWVtbW92ZShidWYsIGJ1ZiArIDQsIHN0cmxlbihidWYgKyA0KSArIDEpOwogCQlyIC09IDQ7
Cg==
--=_efbcdb742a364ca6856da0b04a17f29c--