Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id 73042B5DCC6 for ; Fri, 16 Sep 2011 14:25:26 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 58224-02 for ; Fri, 16 Sep 2011 17:25:20 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0-rc2 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id 2B4A4B5DCD6 for ; Fri, 16 Sep 2011 14:25:20 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p8GHPH6T004593; Fri, 16 Sep 2011 13:25:17 -0400 (EDT) To: Alvaro Herrera cc: Greg Stark , Pg Hackers Subject: Re: /proc/self/oom_adj is deprecated in newer Linux kernels In-reply-to: <1316192401-sup-4726@alvh.no-ip.org> References: <29121.1316185073@sss.pgh.pa.us> <3624.1316191066@sss.pgh.pa.us> <1316192401-sup-4726@alvh.no-ip.org> Comments: In-reply-to Alvaro Herrera message dated "Fri, 16 Sep 2011 14:17:35 -0300" Date: Fri, 16 Sep 2011 13:25:17 -0400 Message-ID: <4592.1316193917@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.404 tagged_above=-5 required=5 tests=BAYES_00=-1.9, RP_MATCHES_RCVD=-0.504 X-Spam-Level: X-Archive-Number: 201109/800 X-Sequence-Number: 194989 Alvaro Herrera writes: > Now the problem is that we have defined the LINUX_OOM_ADJ symbol as > meaning the value we're going to write. Maybe this wasn't the best > choice. I mean, it's very flexible, but it doesn't seem to offer any > benefit over a plain boolean choice. > Is your proposal to create a new LINUX_OOM_SCORE_ADJ cpp symbol with the > same semantics? Yes, that's what I was thinking. We could avoid that if we were going to hard-wire a decision that zero is the thing to write, but I see no reason to place such a restriction on users. Who's to say they might not want backends to adopt some other value? regards, tom lane