Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csEoA-0006uA-Hs for pgsql-hackers@arkaria.postgresql.org; Sun, 26 Mar 2017 20:30:38 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1csEoA-0005HM-4W for pgsql-hackers@arkaria.postgresql.org; Sun, 26 Mar 2017 20:30:38 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1csEmf-0002a5-PI for pgsql-hackers@postgresql.org; Sun, 26 Mar 2017 20:29:05 +0000 Received: from enot.nataraj.su ([195.54.209.170]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csEmd-0001Xy-Gx for pgsql-hackers@postgresql.org; Sun, 26 Mar 2017 20:29:04 +0000 Received: from x200m.localnet (unknown [188.187.8.18]) by enot.nataraj.su (Postfix) with ESMTPSA id 1D774511E2E8 for ; Sun, 26 Mar 2017 16:29:02 -0400 (EDT) From: Nikolay Shaplov To: pgsql-hackers@postgresql.org Subject: Re: [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM Date: Sun, 26 Mar 2017 23:29:01 +0300 Message-ID: <4594068.qjS3tv57iv@x200m> User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <20170326180212.6kdmzc6i2icsax6s@alvherre.pgsql> References: <20170326180212.6kdmzc6i2icsax6s@alvherre.pgsql> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org =D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 26 =D0=BC=D0=B0=D1= =80=D1=82=D0=B0 2017 15:02:12 =D0=92=D1=8B =D0=BD=D0=B0=D0=BF=D0=B8=D1=81= =D0=B0=D0=BB=D0=B8: > Nikolay Shaplov wrote: > > If I would think about it now: we always know how many options we will > > have. So we can just pass this number to palloc and assert if somebody > > adds more options then expected... What do yo think about it. >=20 > I think we need to preserve the ability to add custom options, because > extensions may want to do that. Ok. At least this will not do any harm :-) --=20 Nikolay Shaplov, independent Perl & C/C++ developer. Available for hire. --=20 Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers