Feedback-ID: ie0a040ee:Fastmail
Message-ID: <459ea164-aa38-43dd-8c93-dbb1063d20b5@eisentraut.org>
Date: Thu, 7 May 2026 10:45:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Clean up property graph error messages
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
References: 
 <CAJTYsWXFy1j_T82+M_S9kFxU414tQYnZQD-b82=oL_LbG_5fPQ@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAJTYsWXFy1j_T82+M_S9kFxU414tQYnZQD-b82=oL_LbG_5fPQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/459ea164-aa38-43dd-8c93-dbb1063d20b5%40eisentraut.org>
Precedence: bulk

On 04.05.26 21:57, Ayush Tiwari wrote:
> While looking at the SQL/PGQ property graph error paths, I noticed a
> few small cleanups in propgraphcmds.c.
> 
> The attached patch fixes a user-visible error message from "mismatching
> properties names" to "mismatching property names",

I have fixed that.

> and moves a
> ReleaseSysCache() call before an ERROR ereport in
> check_element_properties().
> 
> The existing code should be cleaned up by
> the resource owner on the ERROR path, but the explicit ReleaseSysCache()
> placed after ereport(ERROR) was unreachable.

I think that's fine.  I don't think the change makes this better.