Message-ID: <45BF5FCF.1080708@microbizz.nl>
Date: Tue, 30 Jan 2007 16:10:07 +0100
From: Adriaan van Os <postgres@microbizz.nl>
User-Agent: Thunderbird 1.5.0.4 (Macintosh/20060516)
MIME-Version: 1.0
To: Bruce Momjian <bruce@momjian.us>
CC: PostgreSQL-patches <pgsql-patches@postgresql.org>
Subject: Re: [HACKERS] [BUGS] BUG #2907: pg_get_serial_sequence quoting
References: <200701300234.l0U2Yr423647@momjian.us>
In-Reply-To: <200701300234.l0U2Yr423647@momjian.us>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Bruce Momjian wrote:
> Adriaan van Os wrote:
>> Tom Lane wrote:
>>> Bruce Momjian <bruce@momjian.us> writes:
>>>>> I presume the reason for that is that the first paramater can be
>>>>> qualified:
>>>>> select pg_get_serial_sequence('"public"."FOO"', 'Ff1');
>>>> Would someone explain why qualification makes us lowercase the first
>>>> parameter by default?  I don't understand it well enough to document it.
>>> The point is that we have to parse the first parameter, whereas the
>>> second one can be taken literally.
>> It still looks inconsistent and ugly. I think the design mistake of pg_get_serial_sequence is that 
>> it takes two parameters rather than one (a fully qualified doublequoted columnname path) or three 
>> (optionally empty schema, tablename, columnname, all three literal).
> 
> I did my best to document the behavior of pg_get_serial_sequence(). 
> There actually is a technical reason why we can't auto-quote the first
> parameter.  Patch applied to HEAD and 8.2.X.

Thanks for the doc change.

Adriaan van Os