Feedback-ID: ie0a040ee:Fastmail
Message-ID: <45b40fd1-1865-44e4-9030-123c52aefda3@eisentraut.org>
Date: Wed, 13 May 2026 17:32:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: egrep is obsolescent
To: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
References: <473272.1778685870@sss.pgh.pa.us>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <473272.1778685870@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/45b40fd1-1865-44e4-9030-123c52aefda3%40eisentraut.org>
Precedence: bulk

On 13.05.26 17:24, Tom Lane wrote:
> While running pgperltidy just now on my recently-updated
> Linux workstation, I got
> 
> $ src/tools/pgindent/pgperltidy .
> egrep: warning: egrep is obsolescent; using grep -E
> 
> OK, that's a bit in-your-face, but it's not inaccurate.
> AFAICT, "egrep" has never been in POSIX, while "grep -E"
> has been there at least since POSIX 2008.
> 
> So I propose the attached patch, which is just s/egrep/grep -E/g.

Looks good to me.

> I did not touch the two usages in port/aix/mkldexport.sh, though.
> I'm not sure what the standardization situation is in AIX, and
> this warning doesn't seem like something they'd do anyway.

It appears that those invocations don't actually need the "e" part of 
egrep, so they could just be grep?

> There is also a reference in configure, which is not a problem
> because it tries "grep -E" first.

Yeah, Autoconf addressed this some decades ago, so it should be fine.