To: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Alexander Lakhin <exclusion@gmail.com>
Subject: A typo in error message
Message-ID: <45c44aa7-7cfa-7f3b-83fd-d8300677fdda@gmail.com>
Date: Wed, 31 Jan 2018 08:47:57 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------78403CD48ECD51B665BA4122"
Content-Language: ru-RU
Precedence: bulk

This is a multi-part message in MIME format.
--------------78403CD48ECD51B665BA4122
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

Please consider committing the attached patch to fix a typo in error 
message.

Best regards,

-- 
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


--------------78403CD48ECD51B665BA4122
Content-Type: text/x-patch;
 name="colums.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="colums.patch"

diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c
index e0d96d7..4894812 100644
--- a/src/backend/parser/parse_utilcmd.c
+++ b/src/backend/parser/parse_utilcmd.c
@@ -668,7 +668,7 @@ transformColumnDefinition(CreateStmtContext *cxt, ColumnDef *column)
 					if (cxt->ofType)
 						ereport(ERROR,
 									(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-									 errmsg("identity colums are not supported on typed tables")));
+									 errmsg("identity columns are not supported on typed tables")));
 					if (cxt->partbound)
 						ereport(ERROR,
 								(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
diff --git a/src/test/regress/expected/identity.out b/src/test/regress/expected/identity.out
index 87ef0d3..627389b 100644
--- a/src/test/regress/expected/identity.out
+++ b/src/test/regress/expected/identity.out
@@ -349,7 +349,7 @@ DROP USER regress_user1;
 -- typed tables (currently not supported)
 CREATE TYPE itest_type AS (f1 integer, f2 text, f3 bigint);
 CREATE TABLE itest12 OF itest_type (f1 WITH OPTIONS GENERATED ALWAYS AS IDENTITY); -- error
-ERROR:  identity colums are not supported on typed tables
+ERROR:  identity columns are not supported on typed tables
 DROP TYPE itest_type CASCADE;
 -- table partitions (currently not supported)
 CREATE TABLE itest_parent (f1 date NOT NULL, f2 text, f3 bigint) PARTITION BY RANGE (f1);

--------------78403CD48ECD51B665BA4122--