Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sRXvK-00GK1E-0r for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Jul 2024 14:03:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sRXvI-005SQ7-MA for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Jul 2024 14:03:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sRXvI-005SNq-5i for pgsql-hackers@lists.postgresql.org; Wed, 10 Jul 2024 14:03:56 +0000 Received: from mail-yb1-xb36.google.com ([2607:f8b0:4864:20::b36]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sRXvF-001Orc-C1 for pgsql-hackers@postgresql.org; Wed, 10 Jul 2024 14:03:55 +0000 Received: by mail-yb1-xb36.google.com with SMTP id 3f1490d57ef6-e0360f890a1so690454276.0 for ; Wed, 10 Jul 2024 07:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20230601.gappssmtp.com; s=20230601; t=1720620231; x=1721225031; darn=postgresql.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=7ncNaRAmzvrKLVKOG+HBVpbXcPmrQHZtfGfhnrn5bnc=; b=OqljAlPTfDkRx9zd2mEJFdT27JjhX1nJ4BtXBrTZD7Hh8haTJcYdwGDLVMlCKcnak/ F0WbZbjtZDi8vF66lrXsFpU1ULhcN6c1iQ0isEahep1Dh2TuSX/tBmpQrevH79w3pPKW AUFRevRD9YAIW8UIzeii8+nICfZ6uDaGnMYbHdrzN7NZp5apf8OrHug/j6yvk2fKeWrQ lKllcxdwtawOohfeNG1HS+0jnbJXI2K0uz6dBNYoADNQMJs6oqDCWToBGJUyPTa0vwXt bMMsf88j6rL5qEMl/DXTPveSGdLFiL31mUA41S/MHxDBHxdki1rL3S8/sjwNV9gYBg4G tIrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720620231; x=1721225031; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7ncNaRAmzvrKLVKOG+HBVpbXcPmrQHZtfGfhnrn5bnc=; b=u3FG5P/gqy2TlG9m26AyhHAoCCRZv/aNgovmaJoqWP2h4u+1HYGaIPrKRz+daXLjnY pYCXahxC023dRBMfSQ1iVMY+S4ucPCF9yldUmhzpw4x455wdqd/nQSM3DbGK5wHbuYKz 92JZvfLDhj8ofhY+Alc3mncHLY7iOyrk1k7yQqDukxd/8p+5cadm+v4YZoAo4T2osJGv 7zI/EqPa2BCmlDz0mQL7YgFoss2fndEdg5F7ylatd9tTcUw3AKuYu3cZ/XvbkbQ7+EWu a7ste4TbMjSPVVQifycShzqZYnf6awNRj5acnZUiY027+6QpiaW9I/xeN15i8vRcdjzY nzIQ== X-Forwarded-Encrypted: i=1; AJvYcCXqtXjDISOcyvMSbSLiDsZRDhOYyOwCgChxiRyy09wEzL1L3B4Wq54ZA9cHz6+cXxfZ13jc7mUw/PDYzWOcRuPvwXOrR9/CMwjKC1yA X-Gm-Message-State: AOJu0Yy7PU3YPLxDidA92iG2sSyg1lMiA3hPjX09dgth9Sg9vlYJx72r mOeWQt7vu3AnIthUI+bgtyFcXi2klu7KnR6Lkz/vCwHPEOqVVF5Uu3L9iO+fY52AiDsqS1FD21G R X-Google-Smtp-Source: AGHT+IGpcISW5mMHg4KGsdo09sfaiUqd7ISrqS6B4R+NAQCQDDzNxy5uEjvdV2l2FTRGAF/S7HGpmw== X-Received: by 2002:a25:2e07:0:b0:e03:60a2:9369 with SMTP id 3f1490d57ef6-e041d290aa6mr4012524276.29.1720620231397; Wed, 10 Jul 2024 07:03:51 -0700 (PDT) Received: from ?IPV6:2605:a601:9180:9800::2bb? ([2605:a601:9180:9800::2bb]) by smtp.googlemail.com with ESMTPSA id 3f1490d57ef6-e041a99af7fsm660804276.53.2024.07.10.07.03.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jul 2024 07:03:50 -0700 (PDT) Message-ID: <45d4c542-7b76-4ab5-92ba-0b4e220f9f6d@dunslane.net> Date: Wed, 10 Jul 2024 10:03:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: tests fail on windows with default git settings To: Tom Lane , Dave Page Cc: Andres Freund , pgsql-hackers@postgresql.org References: <20240707052030.r77hbdkid3mwksop@awork3.anarazel.de> <625384.1720329973@sss.pgh.pa.us> <20240708201649.qaqllje7vc7eyiix@awork3.anarazel.de> <20240708214421.fxunxj2i34faoxq3@awork3.anarazel.de> <68d948a3-704a-4a0e-a7c9-0591f4ade7ce@dunslane.net> <9b08e271-5ae9-4bf2-b328-9123fceb7b98@dunslane.net> <1732390.1720617925@sss.pgh.pa.us> From: Andrew Dunstan Content-Language: en-US Autocrypt: addr=andrew@dunslane.net; keydata= xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/ fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw 49QYe1sn2ZPs In-Reply-To: <1732390.1720617925@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-07-10 We 9:25 AM, Tom Lane wrote: > Dave Page writes: >> On Wed, 10 Jul 2024 at 12:12, Andrew Dunstan wrote: >>> As I was looking at this I wondered if there might be anywhere else that >>> needed adjustment. One thing that occurred to me was that that maybe we >>> should replace the use of "-w" in pg_regress.c with this rather less >>> dangerous flag, so instead of ignoring any white space difference we would >>> only ignore line end differences. The use of "-w" apparently dates back to >>> 2009. >> That seems like a good improvement to me. > +1 > > OK, done. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com