Message-ID: <45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com>
Date: Thu, 20 Jan 2022 10:31:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Subject: Re: pg_upgrade should truncate/remove its logs before running
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>,
 Justin Pryzby <pryzby@telsasoft.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>,
 Andrew Dunstan <andrew@dunslane.net>, Bruce Momjian <bruce@momjian.us>,
 pgsql-hackers@lists.postgresql.org
References: <YcBnT2awK89o6P5I@paquier.xyz>
 <20211221033926.GX17618@telsasoft.com> <YcLYAPsiDlWF6w7o@paquier.xyz>
 <238201.1640184746@sss.pgh.pa.us> <20211222163611.GC17618@telsasoft.com>
 <20220108184857.GI14051@telsasoft.com> <Yd00xmV+rdffAQxf@paquier.xyz>
 <20220111200307.GA14051@telsasoft.com> <Yd5SOupY+FHbiXLD@paquier.xyz>
 <20220112040813.GD14051@telsasoft.com> <YefIHrNYTNH/PML4@paquier.xyz>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <YefIHrNYTNH/PML4@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/45e7680a-b617-1397-afa0-35a793aacefe%40enterprisedb.com>
Precedence: bulk

On 19.01.22 09:13, Michael Paquier wrote:
> - Renaming of the option from --logdir to --outputdir, as this does
> not include only logs.  That matches also better with default value
> assigned in previous patches, aka pg_upgrade_output.d.

I'm afraid that is too easily confused with the target directory. 
Generally, a tool processes data from input to output or from source to 
target or something like that, whereas a log is more clearly something 
separate from this main processing stream.  The desired "output" of 
pg_upgrade is the upgraded cluster, after all.

A wildcard idea is to put the log output into the target cluster.