public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Tom Lane <[email protected]>
To: Andres Freund <[email protected]>
Cc: David Rowley <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: automatically generating node support functions
Date: Mon, 11 Jul 2022 16:09:24 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<b9acf63c-6693-d87c-f010-ca8ad502a39f@enterp! risedb.com>
	<[email protected]>
	<611d2e! [email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 11.07.22 01:09, Tom Lane wrote:
> Andres Freund <[email protected]> writes:
>> I was just rebasing meson ontop of this and was wondering whether the input
>> filenames were in a particular order:

First, things used by later files need to be found in earlier files.  So 
that constrains the order a bit.

Second, the order of the files determines the ordering of the output. 
The current order of the files reflects approximately the order how the 
manual code was arranged.  That could be changed.  We could also just 
sort the node types in the script and dump out everything alphabetically.

> That annoyed me too.  I think it's sensible to list the "main" input
> files first, but I'd put them in our traditional pipeline order:
> 
>> 	nodes/nodes.h \
>> 	nodes/primnodes.h \
>> 	nodes/parsenodes.h \
>> 	nodes/pathnodes.h \
>> 	nodes/plannodes.h \
>> 	nodes/execnodes.h \

The seems worth trying out.

> The rest could probably be alphabetical.  I was also wondering if
> all of them really need to be read at all --- I'm unclear on what
> access/sdir.h is contributing, for example.

could not handle type "ScanDirection" in struct "IndexScan" field 
"indexorderdir"

view thread (80+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: automatically generating node support functions
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox