Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1j9rSw-00074t-J0
	for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Mar 2020 14:27:10 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1j9rSv-0008U9-4W
	for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Mar 2020 14:27:09 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1j9rSu-0008U2-S1
	for pgsql-hackers@lists.postgresql.org; Thu, 05 Mar 2020 14:27:08 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1j9rSo-0000ZX-1M
	for pgsql-hackers@lists.postgresql.org; Thu, 05 Mar 2020 14:27:08 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 025EQsxM000463;
	Thu, 5 Mar 2020 09:26:54 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>,
        Paul Jungwirth <pj@illuminatedcomputing.com>
Subject: Re: useless RangeIOData->typiofunc
In-reply-to: <20200305141859.GA6736@alvherre.pgsql>
References: <20200305141859.GA6736@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Thu, 05 Mar 2020 11:18:59 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <461.1583418414.1@sss.pgh.pa.us>
Date: Thu, 05 Mar 2020 09:26:54 -0500
Message-ID: <462.1583418414@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Thanks -- ISTM it makes more sense to put the FmgrInfo before the
> typioparam too:

> typedef struct RangeIOData
> {
>     TypeCacheEntry *typcache;    /* range type's typcache entry */
>     FmgrInfo    proc;            /* element type's I/O function */
>     Oid         typioparam;      /* element type's I/O parameter */
> } RangeIOData;

Yeah, WFM.  Maybe even rename the FmgrInfo to "typioproc"
or the like?

			regards, tom lane