From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org,
        Thomas Munro <thomas.munro@gmail.com>
Subject: Re: failures in t/031_recovery_conflict.pl on CI
In-reply-to: <20220429200809.uuuseakmhb57sppk@alap3.anarazel.de>
References: <20220409045515.35ypjzddp25v72ou@alap3.anarazel.de>
 <20220409050501.frejv2i46m54keem@alap3.anarazel.de>
 <20220409220054.fqn5arvbeesmxdg5@alap3.anarazel.de>
 <20220409231002.mddrr7mtca7p55v5@alap3.anarazel.de>
 <20220409233107.v7okovwr46xsizfk@alap3.anarazel.de>
 <5111.1649547266@sss.pgh.pa.us>
 <20220412184913.3wrt4olkdiqvicsj@alap3.anarazel.de>
 <907760.1649790322@sss.pgh.pa.us>
 <20220413002626.udl7lll7f3o7nre7@alap3.anarazel.de>
 <20220429200809.uuuseakmhb57sppk@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Fri, 29 Apr 2022 13:08:09 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <465684.1651274819.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 29 Apr 2022 19:26:59 -0400
Message-ID: <465685.1651274819@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/465685.1651274819%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> Questions:
> - I'm planning to backpatch the test as 031_recovery_conflict.pl, even t=
hough
>   preceding numbers are unused. It seems way more problematic to use a
>   different number in the backbranches than have gaps?

+1

> - The test uses pump_until() and wait_for_log(), which don't exist in th=
e
>   backbranches. For now I've just inlined the implementation, but I gues=
s we
>   could also backpatch their introduction?

I'd backpatch --- seems unlikely this will be the last need for 'em.

> pgindent uses some crazy formatting nearby:
>         SendRecoveryConflictWithBufferPin(
>                                           PROCSIG_RECOVERY_CONFLICT_STAR=
TUP_DEADLOCK);

I do not believe that that line break is pgindent's fault.
If you just fold it into one line it should stay that way.

			regards, tom lane