From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@2ndquadrant.com>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Daniel Gustafsson <daniel@yesql.se>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Reporting script runtimes in pg_regress
In-reply-to: 
 <CACPNZCuN6c6fvjX8C61F+ZhLWjbqF3L3OSBEgCKZAzkTiz8erg@mail.gmail.com>
References: <16646.1549770618@sss.pgh.pa.us>
 <E7790843-B885-492B-8537-CC9FB39D5F97@yesql.se>
 <11413.1549835730@sss.pgh.pa.us>
 <6f1657f9-c58c-ba28-0013-d36a6f6fd246@2ndquadrant.com>
 <6418.1549895430@sss.pgh.pa.us>
 <e265e2ae-e92e-5ab9-dc68-60b6cb047b3d@2ndquadrant.com>
 <422e0383-79e1-7c10-5771-1e232e3349ca@2ndquadrant.com>
 <CACPNZCuN6c6fvjX8C61F+ZhLWjbqF3L3OSBEgCKZAzkTiz8erg@mail.gmail.com>
Comments: In-reply-to John Naylor <john.naylor@2ndquadrant.com>
	message dated "Fri, 15 Feb 2019 17:03:13 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4667.1550247893.1@sss.pgh.pa.us>
Date: Fri, 15 Feb 2019 11:24:53 -0500
Message-ID: <4668.1550247893@sss.pgh.pa.us>
Precedence: bulk

John Naylor <john.naylor@2ndquadrant.com> writes:
> On 2/15/19, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>> We should also strive to align "FAILED" properly.  This is currently
>> quite unreadable:
>> 
>> int4                         ... ok (128 ms)
>> int8                         ... FAILED (153 ms)
>> oid                          ... ok (163 ms)
>> float4                       ... ok (231 ms)

> If I may play devil's advocate, who cares how long it takes a test to
> fail? If it's not difficult, leaving the time out for failures would
> make them stand out more.

Actually, I'd supposed that that might be useful info, sometimes.
For example it might help you guess whether a timeout had elapsed.

			regards, tom lane