agora inbox for [email protected]  

help / color / mirror / Atom feed

From: Jan Wieck <[email protected]>
To: Tom Lane <[email protected]>
Cc: PostgreSQL Development <[email protected]>
Subject: Re: usleep feature for pgbench
Date: Thu, 05 Jul 2007 22:58:29 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 7/5/2007 5:30 PM, Tom Lane wrote:
> Jan Wieck <[email protected]> writes:
>> I think I've coded it in a way that if one doesn't use the \usleep 
>> command at all, it will never even call gettimeofday() and use a NULL 
>> timeout in select() as it used to.
> 
> Did you check that the observed performance for non-usleep-using scripts
> didn't change?  If this extra overhead causes a reduction in reported
> TPS rates it would make it hard to compare older and newer tests.

Given pgbench's unpredictability of results ... lets see.

I ran

     dropdb x
     createdb x
     pgbench -i -s10 x
     psql -c 'checkpoint' x
     sleep 1
     psql -c 'checkpoint' x
     pgbench -s10 -c5 -t10000 x
     pgbench -s10 -c5 -t10000 x
     pgbench -s10 -c5 -t10000 x

Original pgbench reported 39, 37 and 33 TPS. Having my patch applied it 
reported 40, 38 and 33 TPS. Inserting a "\usleep 1" after the update to 
accounts of a default equivalent script changed those numbers to 40, 37 
and 33. I interpret that as "does not change observed performance".

> 
> Other than that I've got no objection to it.

Will be committed after adjusting the README.


Jan

-- 
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== [email protected] #

view thread (17+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: usleep feature for pgbench
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox