Message-ID: <469692F6.4050708@hagander.net>
Date: Thu, 12 Jul 2007 22:45:42 +0200
From: Magnus Hagander <magnus@hagander.net>
User-Agent: Thunderbird 2.0.0.5pre (Windows/20070711)
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: compiler warnings on the buildfarm
References: <46962BBD.5000108@kaltenbrunner.cc>
	<17428.1184249229@sss.pgh.pa.us>
	<469653BA.2040004@kaltenbrunner.cc>
	<20917.1184257896@sss.pgh.pa.us> <46966F43.4000905@hagander.net>
	<10521.1184273007@sss.pgh.pa.us>
In-Reply-To: <10521.1184273007@sss.pgh.pa.us>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Tom Lane wrote:
>>> Yeah, this looks like a good list.  I can't readily check the ones from
>>> "eel" as they appear to be in Windows-specific code; anyone else want to
>>> fix those?
> 
>> The pg_ctl one is a windows one, I'll deal with that one.
> 
>> The dirmod one doesn't appear on win32, only cygwin. I don't have a
>> cygwin to check that against, so I'll have to pass on that one.
> 
> Eyeing the code, it looks like the issue is that port.h declares
> pgsymlink if
> 	#if defined(WIN32) && !defined(__CYGWIN__)
> while dirmod.c defines it if
> 	#ifdef WIN32
> 
> So this seems like an actual bug, at least to the extent that pgsymlink
> is being compiled into code but not used on Cygwin.  But more to the
> point, maybe port.h is wrong and we should be using pgsymlink on Cygwin?
> In any case these two files need to be put into sync.

Agreed, but I don't know which should be the master :(

Well, actually. Since it's not #defined in port.h, that should mean it's
not being used anyway? Since the symbol in dirmod.c is pgsymlink, which
shouldn't be referenced directly anywhere. If that's so, then changing
dirmod.c to just exclude the whole thing on CYGWIN should fix the issue.

I don't have a way to test it, but perhaps we should just throw it in
and see if eel breaks on the buildfarm? Unless some poor soul actually
has a cygwin dev box to test on?

//Magnus