Received: from localhost (maia-2.hub.org [200.46.204.187]) by postgresql.org (Postfix) with ESMTP id 7AF429FB50B for ; Thu, 12 Jul 2007 20:03:28 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.187]) (amavisd-maia, port 10024) with ESMTP id 56665-01 for ; Thu, 12 Jul 2007 20:03:15 -0300 (ADT) X-Greylist: whitelisted by SQLgrey-1.7.5 Received: from ms-smtp-04.southeast.rr.com (ms-smtp-04.southeast.rr.com [24.25.9.103]) by postgresql.org (Postfix) with ESMTP id 1BCC69FB3FB for ; Thu, 12 Jul 2007 20:03:23 -0300 (ADT) Received: from [192.168.10.103] (cpe-075-177-135-163.nc.res.rr.com [75.177.135.163]) by ms-smtp-04.southeast.rr.com (8.13.6/8.13.6) with ESMTP id l6CN3CjQ022941; Thu, 12 Jul 2007 19:03:12 -0400 (EDT) Message-ID: <4696B32F.2090308@dunslane.net> Date: Thu, 12 Jul 2007 19:03:11 -0400 From: Andrew Dunstan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.10) Gecko/20070301 Fedora/1.0.8-0.6.2.fc6 pango-text SeaMonkey/1.0.8 MIME-Version: 1.0 To: Tom Lane CC: Stefan Kaltenbrunner , PostgreSQL-development Subject: Re: compiler warnings on the buildfarm References: <46962BBD.5000108@kaltenbrunner.cc> <17428.1184249229@sss.pgh.pa.us> <469653BA.2040004@kaltenbrunner.cc> <13039.1184280316@sss.pgh.pa.us> In-Reply-To: <13039.1184280316@sss.pgh.pa.us> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Symantec AntiVirus Scan Engine X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200707/359 X-Sequence-Number: 105274 Tom Lane wrote: >> animal: eel warnings: 4 >> dirmod.c:206: warning: no previous prototype for 'pgsymlink' >> > > Somebody needs to figure out whether we are supposed to be using > pgsymlink on Cygwin. > According to port.h: * Cygwin has its own symlinks which work on Win95/98/ME where * junction points don't, so use it instead. We have no way of * knowing what type of system Cygwin binaries will be run on. So it looks like we should not be using pgsymlink() on Cygwin, unless we declare that these platforms under Cygwin are no longer supported. cheers andrew