Date: Fri, 13 Jul 2007 14:25:16 +0200
From: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
Subject: Re: compiler warnings on the buildfarm
In-reply-to: <27687.1184290111@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kris Jurka <books@ejurka.com>,
	Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Gorm.Andersen@Sun.COM
Message-id: <46976F2C.4090303@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
References: <46962BBD.5000108@kaltenbrunner.cc>
	<17428.1184249229@sss.pgh.pa.us> <469653BA.2040004@kaltenbrunner.cc>
	<20917.1184257896@sss.pgh.pa.us> <46969A2E.2020608@kaltenbrunner.cc>
	<16415.1184285944@sss.pgh.pa.us>
	<Pine.BSO.4.64.0707122025210.19651@leary.csoft.net>
	<27687.1184290111@sss.pgh.pa.us>
User-Agent: Thunderbird 2.0.0.0 (X11/20070508)

Tom Lane wrote:
> Kris Jurka <books@ejurka.com> writes:
>> So pam_message ** isn't const.
> 
> Ah, thanks.  I see luna_moth is giving the same warning, so it's still
> not const in Solaris 11 either.
> 
> Is it worth working around this?  It's strictly cosmetic AFAICS.
> 
> The main issue in my mind would be how to determine whether to use
> const or not.  If all Solaris releases are like this, and can be
> expected to stay that way,

I think yes. It is defined as X/Open standard says.

> I'd be inclined to just put a "#define
> PAM_CONV_PROC_NOT_CONST" in include/port/solaris.h and drive the
> function declaration off that.  If there's a version dependency
> involved then it gets a lot more complicated, and might not be worth
> the trouble.

Following patch works for me, but I did not test it on other platform.


retrieving revision 1.153
diff -r1.153 auth.c
61c61
<       &pam_passwd_conv_proc,
---
 >       (int (*)())pam_passwd_conv_proc,


	Zdenek