Date: Fri, 13 Jul 2007 15:58:17 +0200
From: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
Subject: Re: compiler warnings on the buildfarm
In-reply-to: <20908.1184334730@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <heikki@enterprisedb.com>,
	Kris Jurka <books@ejurka.com>,
	Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Gorm.Andersen@Sun.COM
Message-id: <469784F9.50400@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
References: <46962BBD.5000108@kaltenbrunner.cc>
	<17428.1184249229@sss.pgh.pa.us> <469653BA.2040004@kaltenbrunner.cc>
	<20917.1184257896@sss.pgh.pa.us> <46969A2E.2020608@kaltenbrunner.cc>
	<16415.1184285944@sss.pgh.pa.us>
	<Pine.BSO.4.64.0707122025210.19651@leary.csoft.net>
	<27687.1184290111@sss.pgh.pa.us> <46976F2C.4090303@sun.com>
	<Pine.BSO.4.64.0707130920510.27066@leary.csoft.net>
	<46977F92.7000000@sun.com>
	<469780E5.80502@enterprisedb.com> <20908.1184334730@sss.pgh.pa.us>
User-Agent: Thunderbird 2.0.0.0 (X11/20070508)

Tom Lane wrote:
> Heikki Linnakangas <heikki@enterprisedb.com> writes:
>> Zdenek Kotala wrote:
>>> I don't see any "const" keyword there.
> 
>> Right after that:
> 
>>> where int conv(int num_msg, const struct pam_message **msg, struct pam_response **resp, void *appdata_ptr); 
> 
>> How confusing...
> 
> And the pam_start page he cited earlier has a different set of typos in
> its version of the struct :-(.  Still, that's two out of three places
> that say it's const, and Solaris appears to be the only implementation
> that has chosen to read it as not const.

Yes, Agree. I try to send request to security team for explanation. 
Maybe original author also overlooked it as me today :-).

		Zdenek