Received: from localhost (maia-1.hub.org [200.46.204.191]) by postgresql.org (Postfix) with ESMTP id 4C1929FBDDF for ; Tue, 17 Jul 2007 12:56:50 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.191]) (amavisd-maia, port 10024) with ESMTP id 61946-02 for ; Tue, 17 Jul 2007 12:56:47 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.5 Received: from gmp-ea-fw-1.sun.com (gmp-ea-fw-1.sun.com [192.18.1.36]) by postgresql.org (Postfix) with ESMTP id B586D9FB972 for ; Tue, 17 Jul 2007 12:56:43 -0300 (ADT) Received: from d1-emea-09.sun.com ([192.18.2.119]) by gmp-ea-fw-1.sun.com (8.13.6+Sun/8.12.9) with ESMTP id l6HFuggC004173 for ; Tue, 17 Jul 2007 15:56:42 GMT Received: from conversion-daemon.d1-emea-09.sun.com by d1-emea-09.sun.com (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) id <0JLB00801YVUFN00@d1-emea-09.sun.com> (original mail from Zdenek.Kotala@Sun.COM) for pgsql-hackers@postgresql.org; Tue, 17 Jul 2007 16:56:42 +0100 (BST) Received: from [129.157.18.76] by d1-emea-09.sun.com (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPSA id <0JLB009NIYYHAIU9@d1-emea-09.sun.com>; Tue, 17 Jul 2007 16:56:42 +0100 (BST) Date: Tue, 17 Jul 2007 17:56:08 +0200 From: Zdenek Kotala Subject: Re: compiler warnings on the buildfarm In-reply-to: <24244.1184687156@sss.pgh.pa.us> To: Tom Lane Cc: Stefan Kaltenbrunner , pgsql-hackers@postgresql.org, peter_e@gmx.net Message-id: <469CE698.7050606@sun.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-2 Content-transfer-encoding: 7BIT References: <46962BBD.5000108@kaltenbrunner.cc> <200707121744.22730.peter_e@gmx.net> <4696548D.7020406@kaltenbrunner.cc> <469769AD.5000703@sun.com> <46976DD2.3050202@kaltenbrunner.cc> <46977B20.9020100@sun.com> <469A60C8.6050404@kaltenbrunner.cc> <469BA8DE.1030004@sun.com> <469BE2DE.6070102@kaltenbrunner.cc> <469CDF6B.6080209@sun.com> <24244.1184687156@sss.pgh.pa.us> User-Agent: Thunderbird 2.0.0.0 (X11/20070508) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200707/523 X-Sequence-Number: 105438 Tom Lane napsal(a): > Zdenek Kotala writes: >> E_FUNC_HAS_NO_RETURN_STMT is there because main is leaved by exit() instead >> return. And In another case It should be regular warning. > > That should be gone now; I changed the two places that triggered it. > I'd suggest not disabling that warning. Yes I agree. Did you also clean up on old branches? If not I think we can live with this warning on old branches. Zdenek