public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Tomas Vondra <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Parallel CREATE INDEX for BRIN indexes
Date: Fri, 16 Aug 2024 17:32:17 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAEze2Wi9nWxx2wDTHaBJi36JLQ+-JcTU0BcRh+yd8AR-9VNxTw@mail.gmail.com>
	<[email protected]>
	<CAEze2Wi1X=+M9=k2FUAL-b0rfvVK08q-x+-+wkam+T-8tcbgrw@mail.gmail.com>
	<[email protected]>
	<CAEze2WiMsPZg=xkvSF_jt4=69k6K7gz5B8V2wY3gCGZ+1BzCbQ@mail.gmail.com>
	<[email protected]>
	<CAEze2WjmoEo9UFpsiq_1sngOnZArjUMjN8wyzcQvegLFDddYUQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 16.08.24 11:22, Tomas Vondra wrote:
>> These pageinspect tests added a new use of the md5() function.  We got
>> rid of those in the tests for PG17.  You could write the test case with
>> something like
>>
>>   SELECT (CASE WHEN (mod(i,231) = 0) OR (i BETWEEN 3500 AND 4000) THEN
>> NULL ELSE i END),
>> -       (CASE WHEN (mod(i,233) = 0) OR (i BETWEEN 3750 AND 4250) THEN
>> NULL ELSE md5(i::text) END),
>> +       (CASE WHEN (mod(i,233) = 0) OR (i BETWEEN 3750 AND 4250) THEN
>> NULL ELSE encode(sha256(i::text::bytea), 'hex') END),
>>          (CASE WHEN (mod(i,233) = 0) OR (i BETWEEN 3850 AND 4500) THEN
>> NULL ELSE (i/100) + mod(i,8) END)
>>
>> But this changes the test output slightly and I'm not sure if this gives
>> you the data distribution that you need for you test.  Could your check
>> this please?
>>
> 
> I think this is fine. The output only changes because sha256 produces
> longer values than md5, so that the summaries are longer the index gets
> a page longer. AFAIK that has no impact on the test.

Ok, I have committed that.  Thanks for checking.

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Parallel CREATE INDEX for BRIN indexes
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox