Subject: Re: Re: Minimal logical decoding on standbys
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Andres Freund
	<andres@anarazel.de>
CC: Ibrar Ahmed <ibrar.ahmad@gmail.com>, Amit Khandekar
	<amitdkhan.pg@gmail.com>, <fabriziomello@gmail.com>, Alvaro Herrera
	<alvherre@2ndquadrant.com>, tushar <tushar.ahuja@enterprisedb.com>, "[pgdg]
 Robert Haas" <robertmhaas@gmail.com>, Rahila Syed
	<rahila.syed@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
References: <20210407170954.xbovgh3xdrnogg7w@alap3.anarazel.de>
 <20210407203218.pestfxu7watrnog4@alap3.anarazel.de>
 <20210408034713.auf7oaxyymu2kc7n@alap3.anarazel.de>
 <26c6f320-98f0-253c-f8b5-df1e7c1f6315@amazon.com>
 <8d263a6b-a99f-0f9b-43ba-e8967c386f2b@amazon.com>
 <2feee395-959b-6d53-369a-c00f8f2fa6c5@amazon.com>
 <CALtqXTfXsyq-G7x3Ti3bm4KgpepqZA_-ZukzJ5W5vFLjRrhGSg@mail.gmail.com>
 <fa90206a-6bf1-2121-cf0c-15b0734a2731@amazon.com>
 <20210727172257.ekvkspdqaeh2etfg@alap3.anarazel.de>
 <69aad0bf-697a-04e1-df6c-0920ec8fa528@amazon.com>
 <20210802160133.uugcce5ql4m5mv5m@alap3.anarazel.de>
 <7094ac62-340f-9b23-3af6-e24fe08c8697@amazon.com>
 <47606911-cf44-5a62-21d5-366d3bc6e445@enterprisedb.com>
From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
Message-ID: <46ec17a8-3c5d-7152-f6b0-ac122a5d0789@amazon.com>
Date: Thu, 26 Aug 2021 14:00:59 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <47606911-cf44-5a62-21d5-366d3bc6e445@enterprisedb.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/46ec17a8-3c5d-7152-f6b0-ac122a5d0789%40amazon.com>
Precedence: bulk

Hi Peter,

On 8/26/21 1:35 PM, Peter Eisentraut wrote:
> CAUTION: This email originated from outside of the organization. Do 
> not click links or open attachments unless you can confirm the sender 
> and know the content is safe.
>
>
>
> I noticed the tests added in this patch set are very slow.  Here are
> some of the timings:
>
> ...
> [13:26:59] t/018_wal_optimize.pl ................ ok    13976 ms
> [13:27:13] t/019_replslot_limit.pl .............. ok    10976 ms
> [13:27:24] t/020_archive_status.pl .............. ok     6190 ms
> [13:27:30] t/021_row_visibility.pl .............. ok     3227 ms
> [13:27:33] t/022_crash_temp_files.pl ............ ok     2296 ms
> [13:27:36] t/023_pitr_prepared_xact.pl .......... ok     3601 ms
> [13:27:39] t/024_archive_recovery.pl ............ ok     3937 ms
> [13:27:43] t/025_stuck_on_old_timeline.pl ....... ok     4348 ms
> [13:27:47] t/026_standby_logical_decoding.pl .... ok   117730 ms <<<
>
> Is it possible to improve this?

Thanks for looking at it.

Once the walsender race conditions mentioned by Andres in [1] are 
addressed then i think that the tests should be much more faster.

I'll try to have a look soon and come with a proposal to address those 
race conditions.

Thanks

Bertrand

[1]: 
https://www.postgresql.org/message-id/20210802160133.uugcce5ql4m5mv5m%40alap3.anarazel.de