From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Steele <david@pgmasters.net>
cc: Amit Langote <amitlangote09@gmail.com>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Views no longer in rangeTabls?
In-reply-to: <462cd5de-3ade-989b-0798-7e1cab562991@pgmasters.net>
References: <3953179e-9540-e5d1-a743-4bef368785b0@pgmasters.net> <CA+HiwqFC0xDCCiXbUjb-xisxo9PPuA8_ykn8Fz+6RbBJBE8mVA@mail.gmail.com> <462cd5de-3ade-989b-0798-7e1cab562991@pgmasters.net>
Comments: In-reply-to David Steele <david@pgmasters.net>
	message dated "Fri, 09 Jun 2023 17:46:48 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <470643.1686327286.1@sss.pgh.pa.us>
Date: Fri, 09 Jun 2023 12:14:46 -0400
Message-ID: <470644.1686327286@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/470644.1686327286%40sss.pgh.pa.us>
Precedence: bulk

David Steele <david@pgmasters.net> writes:
> Thank you, this was very helpful. I am able to get the expected result 
> now with:

> /* We only care about tables/views and can ignore subqueries, etc. */
> if (!(rte->rtekind == RTE_RELATION ||
>       (rte->rtekind == RTE_SUBQUERY && OidIsValid(rte->relid))))
>      continue;

Right, that matches places like add_rtes_to_flat_rtable().

> One thing, though, rte->relkind is not set for views, so I still need to 
> call get_rel_relkind(rte->relid). Not a big deal, but do you think it 
> would make sense to set rte->relkind for views?

If you see "rte->rtekind == RTE_SUBQUERY && OidIsValid(rte->relid)",
it's dead certain that relid refers to a view, so you could just wire
in that knowledge.

			regards, tom lane