public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: Alvaro Herrera <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: cataloguing NOT NULL constraints
Date: Tue, 5 Sep 2023 13:29:47 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
On 31.08.23 12:02, Alvaro Herrera wrote:
> In constraint_column_usage, you're adding a relkind to the catalog scan
> that goes through pg_depend for CHECK constraints. Here we can rely on
> a simple conkey[1] check and a separate UNION ALL arm[q5]; this is also
> faster when there are many tables.
>
> The third view definition looks ok. It's certainly very nice to be able
> to delete XXX comments there.
The following information schema views are affected by the not-null
constraint catalog entries:
1. CHECK_CONSTRAINTS
2. CONSTRAINT_COLUMN_USAGE
3. DOMAIN_CONSTRAINTS
4. TABLE_CONSTRAINTS
Note that 1 and 3 also contain domain constraints. So as long as the
domain not-null constraints are not similarly catalogued, we can't
delete the separate not-null union branch. (3 never had one, so
arguably a bit buggy.)
I think we can fix up 4 by just deleting the not-null union branch.
For 2, the simple fix is also easy, but there are some other options, as
you discuss above.
How do you want to proceed?
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: cataloguing NOT NULL constraints
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox