public inbox for [email protected]  

help / color / mirror / Atom feed

From: Drouvot, Bertrand <[email protected]>
To: Imseih (AWS), Sami <[email protected]>
To: Michael Paquier <[email protected]>
Cc: David Zhang <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [BUG] pg_stat_statements and extended query protocol
Date: Thu, 23 Mar 2023 09:33:16 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<ZA0/[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Hi,

On 3/22/23 10:35 PM, Imseih (AWS), Sami wrote:
>> What about using an uint64 for calls? That seems more appropriate to me (even if
>> queryDesc->totaltime->calls will be passed (which is int64), but that's already
>> also the case for the "rows" argument and queryDesc->totaltime->rows_processed)
> 
> That's fair
> 
> 
>> I'm not sure it's worth mentioning that the new counters are "currently" used with the ExecutorRun.
> 
> Sure, I suppose these fields could be used outside of ExecutorRun. Good point.
> 
> 
>> Also, I wonder if "rows" (and not rows_processed) would not be a better naming.
> 
> Agree.
> 
> I went with rows_processed initially, since it was accumulating es_processed,
> but as the previous point, this instrumentation could be used outside of
> ExecutorRun.
> 
> v3 addresses the comments.
> 

Thanks! LGTM and also do confirm that, with the patch, the JDBC test does show the correct results.

That said, not having a test (for the reasons you explained up-thread) associated with the patch worry me a bit.

But, I'm tempted to say that adding new tests could be addressed separately though (as this patch looks pretty straightforward).

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

view thread (22+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [BUG] pg_stat_statements and extended query protocol
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox