Subject: Re: psql: \dl+ to list large objects privileges
To: Georgios Kokolatos <gkokolatos@protonmail.com>,
 pgsql-hackers@lists.postgresql.org
Cc: Pavel Luzanov <pluzanov@postgrespro.ru>
References: <6d722115-6297-bc53-bb7f-5f150e765299@postgrespro.ru>
 <90da33e5-5886-11f0-d22f-b2ff8b2d4b99@postgrespro.ru>
 <163067194414.1167.8140856874411625212.pgcf@coridan.postgresql.org>
From: Pavel Luzanov <p.luzanov@postgrespro.ru>
Message-ID: <47402814-d495-4d9d-dfda-e3d3a67c1ea2@postgrespro.ru>
Date: Fri, 3 Sep 2021 16:43:43 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: 
 <163067194414.1167.8140856874411625212.pgcf@coridan.postgresql.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/47402814-d495-4d9d-dfda-e3d3a67c1ea2%40postgrespro.ru>
Precedence: bulk

Hello,

Thank you very mush for review.

I will prepare a new version of the patch according to your comments. 
For now, I will answer this question:

> I will also inquire as to the need for renaming the function `do_lo_list` to
> `listLargeObjects` and its move to describe.c. from large_obj.c. In itself it is
> not necessarily a blocking point, though it will require some strong arguments
> for doing so.

I understand that I needed a good reason for such actions.

On the one hand all the commands for working with large objects are in 
large_obj.c. On the other hand, all commands for displaying the contents 
of system catalogs are in describe.c. The function do_lo_list belongs to 
both groups.

The main reason for moving the function to describe.c is that I wanted 
to use the printACLColumn function to display lomacl column. 
printACLColumn function is used in all the other commands to display 
privileges and this function is locally defined in describe.c and there 
is no reason to make in public.

Another option is to duplicate the printACLColumn function (or its 
contents) in large_obj.c. This seemed wrong to me.
Is it any other way?

Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company