From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Daniel Gustafsson <daniel@yesql.se>, pgsql-hackers@lists.postgresql.org
Subject: Re: Reporting script runtimes in pg_regress
In-reply-to: <422e0383-79e1-7c10-5771-1e232e3349ca@2ndquadrant.com>
References: <16646.1549770618@sss.pgh.pa.us>
 <E7790843-B885-492B-8537-CC9FB39D5F97@yesql.se>
 <11413.1549835730@sss.pgh.pa.us>
 <6f1657f9-c58c-ba28-0013-d36a6f6fd246@2ndquadrant.com>
 <6418.1549895430@sss.pgh.pa.us>
 <e265e2ae-e92e-5ab9-dc68-60b6cb047b3d@2ndquadrant.com>
 <422e0383-79e1-7c10-5771-1e232e3349ca@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Fri, 15 Feb 2019 15:13:48 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <474.1550242484.1@sss.pgh.pa.us>
Date: Fri, 15 Feb 2019 09:54:44 -0500
Message-ID: <475.1550242484@sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2019-02-15 14:32, Peter Eisentraut wrote:
>> test event_trigger                ... ok      128 ms
>> test fast_default                 ... ok      173 ms
>> test stats                        ... ok      637 ms

That looks reasonable, although on machines where test runtimes run
into the tens of seconds, there's not going to be nearly as much
whitespace as this example suggests.

> We should also strive to align "FAILED" properly.

Hmm.  The reasonable ways to accomplish that look to be either
(a) pad "ok" to the width of "FAILED", or (b) rely on emitting a tab.
I don't much like either, especially from the localization angle.
One should also note that FAILED often comes along with additional
verbiage, such as "(ignored)" or a note about process exit status;
so I think making such cases line up totally neatly is a lost cause
anyway.

How do you feel about letting it do this:

      int4                         ... ok      128 ms
      int8                         ... FAILED      153 ms
      oid                          ... ok      163 ms
      float4                       ... ok      231 ms

			regards, tom lane