Feedback-ID: i131946ab:Fastmail
Message-ID: <475c3dff-158d-effa-5a0f-d025d37a3eac@enterprisedb.com>
Date: Wed, 22 Mar 2023 07:45:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.0
Subject: Re: Set arbitrary GUC options during initdb
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <2844176.1674681919@sss.pgh.pa.us>
 <8a8fda29-5a68-ba68-a2ff-8d17602b3762@enterprisedb.com>
 <3331317.1674833645@sss.pgh.pa.us>
 <CA+TgmoY4gndkosTZf=Zs1_SfsfO_13c7-yazryweZvLwSTHLgA@mail.gmail.com>
 <3332912.1674834822@sss.pgh.pa.us>
 <CAKFQuwauwt+w8HbtU_-Mqo-aZ1Qjsah13E5_iFEUTVpVc1PTAw@mail.gmail.com>
 <3337560.1674837348@sss.pgh.pa.us> <3527270.1674849724@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <3527270.1674849724@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/475c3dff-158d-effa-5a0f-d025d37a3eac%40enterprisedb.com>
Precedence: bulk

On 27.01.23 21:02, Tom Lane wrote:
> I wrote:
>>>> Anyway, it seems like I gotta work harder.  I'll produce a
>>>> new patch.
> 
> The string-hacking was fully as tedious as I expected.  However, the
> output looks pretty nice, and this does have the advantage that the
> pre-programmed substitutions become a lot more robust: they are no
> longer dependent on the initdb code exactly matching what is in
> postgresql.conf.sample.

This patch looks good to me.  It's a very nice simplification of the 
initdb.c code, even without the new feature.

I found that the addition of

#include <ctype.h>

didn't appear to be necessary.  Maybe it was required before 
guc_value_requires_quotes() was changed?

I would remove the

#if DEF_PGPORT != 5432

This was in the previous code too, but now if we remove it, then we 
don't have any more hardcoded 5432 left, which seems like a nice 
improvement in cleanliness.