Message-ID: <477c16c8-7ea4-20fc-38d5-ed3a77ed616c@oss.nttdata.com>
Date: Fri, 19 Nov 2021 17:18:22 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.0
Content-Language: en-US
To: pgsql-hackers@lists.postgresql.org
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Subject: issue in pgfdw_report_error()?
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/477c16c8-7ea4-20fc-38d5-ed3a77ed616c%40oss.nttdata.com>
Precedence: bulk

Hi,

pgfdw_report_error() in postgres_fdw is implemented to report the message
"could not obtain ..." if message_primary is NULL as follows.
But, just before this ereport(), message_primary is set to
pchomp(PQerrorMessage()) if it's NULL. So ISTM that message_primary is
always not NULL in ereport() and the message "could not obtain ..." is
never reported. Is this a bug?

-------------------
if (message_primary == NULL)
	message_primary = pchomp(PQerrorMessage(conn));

ereport(elevel,
		(errcode(sqlstate),
		 message_primary ? errmsg_internal("%s", message_primary) :
		 errmsg("could not obtain message string for remote error"),
-------------------


If this is a bug, IMO the following change needs to be applied. Thought?

-------------------
                 ereport(elevel,
                                 (errcode(sqlstate),
-                                message_primary ? errmsg_internal("%s", message_primary) :
+                                (message_primary != NULL && message_primary[0] != '\0') ?
+                                errmsg_internal("%s", message_primary) :
                                  errmsg("could not obtain message string for remote error"),
-------------------

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION