Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9z1z-00059E-2i for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Jun 2023 02:17:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q9z1y-00009A-28 for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Jun 2023 02:17:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9z1x-000091-P7 for pgsql-hackers@lists.postgresql.org; Fri, 16 Jun 2023 02:17:41 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q9z1v-002S3q-9N for pgsql-hackers@lists.postgresql.org; Fri, 16 Jun 2023 02:17:40 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 5B15460256; Fri, 16 Jun 2023 11:17:37 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.8 at oss.nttdata.com MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 16 Jun 2023 11:17:37 +0900 From: Masahiro Ikeda To: "Drouvot, Bertrand" Cc: Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: Support to define custom wait events for extensions In-Reply-To: References: User-Agent: Roundcube Webmail/1.4.11 Message-ID: <478dcb9c6e76be3dc9cbadfaeb8247b8@oss.nttdata.com> X-Sender: ikedamsh@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-06-15 22:21, Drouvot, Bertrand wrote: > Hi, > > On 6/15/23 10:00 AM, Michael Paquier wrote: >> On Thu, Jun 15, 2023 at 03:06:01PM +0900, Masahiro Ikeda wrote: >>> Currently, only one PG_WAIT_EXTENSION event can be used as a >>> wait event for extensions. Therefore, in environments with multiple >>> extensions are installed, it could take time to identify which >>> extension is the bottleneck. >> >> Thanks for taking the time to implement a patch to do that. > > +1 thanks for it! > >> >>> I want to know your feedbacks. Please feel free to comment. >> >> I think that's been cruelly missed. > > Yeah, that would clearly help to diagnose which extension(s) is/are > causing the waits (if any). > > I did not look at the code yet (will do) but just wanted to chime in > to support the idea. Great! Thanks. Regards, -- Masahiro Ikeda NTT DATA CORPORATION