Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1sum-0000Eu-Cw for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jan 2021 15:27:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l1sul-0004n0-0S for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jan 2021 15:27:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1suk-0004lN-PS for pgsql-hackers@lists.postgresql.org; Tue, 19 Jan 2021 15:27:26 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1sui-00078b-Pd for pgsql-hackers@lists.postgresql.org; Tue, 19 Jan 2021 15:27:26 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 10JFRLYc479373; Tue, 19 Jan 2021 10:27:21 -0500 From: Tom Lane To: James Hilliard cc: pgsql-hackers@lists.postgresql.org, Sergey Shinderuk , Thomas Munro Subject: Re: [PATCH 1/1] Fix detection of pwritev support for OSX. In-reply-to: <20210119111625.20435-1-james.hilliard1@gmail.com> References: <20210119111625.20435-1-james.hilliard1@gmail.com> Comments: In-reply-to James Hilliard message dated "Tue, 19 Jan 2021 04:16:25 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <479371.1611070041.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Tue, 19 Jan 2021 10:27:21 -0500 Message-ID: <479372.1611070041@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk James Hilliard writes: > Fixes: > gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-state= ment -Werror=3Dvla -Wendif-labels -Wmissing-format-attribute -Wformat-secu= rity -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -O2 -I= ../../../../src/include -isysroot /Applications/Xcode.app/Contents/Develo= per/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -c -o fd.o = fd.c > fd.c:3661:10: warning: 'pwritev' is only available on macOS 11.0 or newe= r [-Wunguarded-availability-new] We already dealt with that by not selecting an SDK newer than the underlying OS (see 4823621db). I do not believe that your proposal is more reliable than that approach, and it's surely uglier. Are we really going to abandon Autoconf's built-in checking method every time Apple adds an API they should have had ten years ago? If so, you forgot preadv ... regards, tom lane