Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 4B70D2E02A0 for ; Fri, 7 Mar 2008 20:23:45 -0400 (AST) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 67183-08 for ; Fri, 7 Mar 2008 20:23:42 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.5 Received: from mail.esilo.com (downloads.esilo.com [63.150.152.211]) by postgresql.org (Postfix) with ESMTP id A19562E0248 for ; Fri, 7 Mar 2008 20:23:42 -0400 (AST) Received: from [192.168.1.103] (c-76-110-102-88.hsd1.fl.comcast.net [76.110.102.88]) (authenticated bits=0) by mail.esilo.com (8.13.1/8.13.1) with ESMTP id m280Naxm006845; Fri, 7 Mar 2008 19:23:37 -0500 Message-ID: <47D1DC94.5060901@esilo.com> Date: Fri, 07 Mar 2008 19:23:48 -0500 From: Andrew Chernow User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: Tom Lane CC: Heikki Linnakangas , Alvaro Herrera , "Joshua D. Drake" , PostgreSQL-development Subject: Re: Commitfest process References: <47D1521E.8090606@enterprisedb.com> <20080307101413.7d191e52@commandprompt.com> <47D18D80.2050107@enterprisedb.com> <20080307105047.2e34a156@commandprompt.com> <20080307194612.GB16862@alvh.no-ip.org> <47D19E18.4060303@enterprisedb.com> <28031.1204926346@sss.pgh.pa.us> In-Reply-To: <28031.1204926346@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200803/213 X-Sequence-Number: 115014 > This is reasonable for the sort of medium-to-large patch that the author > has put a lot of time into. But we also get a lot of small one-off > patches where it's not so reasonable. Now of course many of those get > applied right away, but not all. > Just a thought... maybe a distinction should be made between "quick-fix" patches and things that would require more review due to behavior changes or new features. Seems reasonable to treat something like HOT and a one line patch differently. Not sure where the magic line would be drawn: size of patch, is it a bug fix or a new feature, requires extensive testing (more time), etc... I do think it is overkill to have a wiki entry for a one line patch with a 30 minute life-span (either thrown out or applied). -- Andrew Chernow eSilo, LLC every bit counts http://www.esilo.com/