Subject: Re: [PATCH] remove pg_standby
To: Justin Pryzby <pryzby@telsasoft.com>
References: <20201029024412.GP5380@telsasoft.com>
 <3de458c1-2299-92a8-1fa1-d59ac385140c@enterprisedb.com>
 <20201121194105.GO24784@telsasoft.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Tom Lane <tgl@sss.pgh.pa.us>,
 Stephen Frost <sfrost@snowman.net>, Ian Lawrence Barwick
 <barwick@gmail.com>, pgsql-hackers@postgresql.org
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Organization: EnterpriseDB
Message-ID: <47c1a857-3e42-489d-6be3-ee229f970d0c@enterprisedb.com>
Date: Wed, 25 Nov 2020 10:04:12 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20201121194105.GO24784@telsasoft.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-11-21 20:41, Justin Pryzby wrote:
> On Fri, Nov 20, 2020 at 05:26:54PM +0100, Peter Eisentraut wrote:
>> On 2020-10-29 03:44, Justin Pryzby wrote:
>>> diff --git a/doc/src/sgml/contrib.sgml b/doc/src/sgml/contrib.sgml
>>> index 4e833d79ef..be4292ec33 100644
>>> --- a/doc/src/sgml/contrib.sgml
>>> +++ b/doc/src/sgml/contrib.sgml
>>> @@ -199,6 +199,5 @@ pages.
>>>       part of the core <productname>PostgreSQL</productname> distribution.
>>>      </para>
>>> - &pgstandby;
>>>     </sect1>
>>>    </appendix>
>>
>> With this removal, that section becomes empty.  So you probably want to
>> clean up or reorganize this a bit.
>>
>> See https://www.postgresql.org/docs/devel/contrib-prog.html for the context.
> 
> Oops.  I guess I'd write something like this.  If we just remove it, then
> there'd no place to add a new server application, and "client applications"
> would be the only subsection.

I have committed the typo fix.  I don't have a well-formed opinion yet 
about whether all the reservations about removing pg_standby have been 
addressed.