Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlaix-0005Uu-LL for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Jun 2020 16:15:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jlaiw-00026k-FT for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Jun 2020 16:15:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlaiv-00026c-Gl for pgsql-hackers@lists.postgresql.org; Wed, 17 Jun 2020 16:15:38 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jlair-0004Aw-Ri for pgsql-hackers@postgresql.org; Wed, 17 Jun 2020 16:15:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oxXi7HGPACeJCDVZaF558LRtzYVB5tddj2AqN9eLqAg=; b=o5W5PCOo3yW193LC3WekFiBV+1 jdxRs3qTOYJ6cmycfh5I7B74TtB/v7F4ndtoMpmeaXyZM4rxNBnr1DDNnrsfbixduomT6HkE1iGny jEIa70YslAXeXoPwK4916qXPjFc9HXAWueUnOPJwGBX+DwwvwIMINB6PinmxsitN9ryxHr2IJ31lO pShDn6rFHUql5ZZeOU5MauwRoX6TV8y7MeqYRQr+4hH07VbqHhxnhdT8BR7Y+s8a60YQ8hFk//GDR BR+3hf3sM1pKGFTzsR4VvrxNtCB2CEsTDRG7u3jcebeGr7i+lZBuhLuSsHfTMa5V+KeSawgAS0T5K Wd78PP7Q==; Received: from pool-173-56-10-231.nycmny.fios.verizon.net ([173.56.10.231] helo=Ph33rHippo.local) by meldrar.postgresql.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jlain-0000Q5-39; Wed, 17 Jun 2020 16:15:31 +0000 Subject: Re: language cleanups in code and docs To: Magnus Hagander , Andrew Dunstan Cc: Andres Freund , PostgreSQL-development References: <20200615182235.x7lch5n6kcjq4aue@alap3.anarazel.de> <0357f124-8017-1563-6dbf-04ed10d7c041@2ndQuadrant.com> From: "Jonathan S. Katz" Autocrypt: addr=jkatz@postgresql.org; keydata= mQINBFtShwABEAC7PNHDUOTYuifpUCk23KqfxdQQkn4nkoxOXRK0+rAj36FiwqGB4TJFuOVZ sDFAEiSlC8Jt4y5Cs7B5tetT8JNd2cs6zp/udMJJDz9d65O9PDpdlMgAmIiTzpLlSdx8FG56 DTksaDv1d8j3cTJPSE4/fWSxqzA7o3Y9UuL7atZPrzfImgpRKs0of7elIHwOa8GucjyhYqcR h60wFBJc2KXqQdDYRTZy43DSnY/0VNc0omiH355fustvpm+m5HjD3w7qZyfN3fpKJpnX1LCF f3MnPHaDGITIYGRCBXvf0UqUtD6OEVWPv2C2gyqWMIpWmZTOgDufltKyIByKBoS9x0PlFkij 04X3KODCngt+N8Ssc9OICc6QSxhjoP48PYPdmiTmkrGuf0LX084wj1xeo1NX7XxZK39F6dTJ DhsIiW0sNS0xMxQHLHG9VLbPjx3SANQBh6BuryPz5ZupW9/TIDmkvprtU/oXfKgtfYm3fxmk EctxbWrEPsFTFPyuMqQu6l+xyQv0s1VLZfjNWaua6H1/gGoIt6kRnn5qMXDVVpijuWkHbv7G ngaQMd258UrrOEHnnjzhQ7jxMWV9D+emxbAtlIxnYvCWlV4IwAQhEHfvudqYaIY3hNWrvQ6H GB2KXoTZYN9g5djm14/5nj1IU5zOcovkjJnKhoo9iStnpFF2cwARAQABtCdKb25hdGhhbiBT LiBLYXR6IDxqa2F0ekBwb3N0Z3Jlc3FsLm9yZz6JAlQEEwEIAD4CGwMFCQeGH4AFCwkIBwIG FQoJCAsCBBYCAwECHgECF4AWIQT6hLaVryv3miBkP/HxBJxynxxlJwUCW1KJJQAKCRDxBJxy nxxlJwjrD/kBgqsW4QpNpTFw7ifRokZV08CCX4huPBJQ91rrv+UEWlEcotFBHVkYyHnpzARl tcZxhJ9CbFxjniH9cOTty5T/O1yolbOHtZSW8Z8aWV6BVEbjMb+BFxSSLm7RnvJdzQbGCZq2 ZZvfVpB6z3EHYph4KDdVKvMFjoLskxmdS1DE0tE3zTxvoQsi24Q+HOS07kUjs6fsu/WICMfz mgO++AWG9Y0CvN0mm4TkujESzyKM9E5irD+leEMIcddl51Aa2c/VMfBXQbRmpHIgUFTmuHQD CnQih+9i3OJAksDg66SP8a7yiXv5mwvyDi1EfTGVKYR2j+pwyjwnC3oIbvDMmB3uTn2JIjnT iZKPVtAcAylXjubFltihQgNyuShdP4W+kBwZizhUFqUVL8Anx+KoytYmJPfMRFLGuK4obXKq a2ZS3k9KB+H+isOx2nFJOsc7V360Zp1DVaNmuiK10TT6QndShSPaqkJqFtCb6r92rZ9sZM/L 3vtCI4Rrl3Pt1MgtENXupS8gZpJnAYS0j5A1PAZ09r6ANoaeMHspF+5J5fOHeEvqphXr36mm a83Vl1t4orPb0+QmmijmlpseDU63M88Aw5p3c4qj7t8Qr2EZ5zrn7/sFn5wOfbs8Nymxafif QCnlV2vg9p0m7vSk/yLJ4PFZvs52FgqAGRCdRn0s2EC99bkCDQRbUocAARAAv8ho/toQ9DG3 j4f9h9n1aRHr2FlviN2Utpy6L8+dfDggO0geilmkGQOolZ2E60gGfye/kUtF9W3NByO4hxDR 9u6qbOXcdqnuA+cc68EfqlWFJrVtYFxt0h4ElWYOYnIezKthriWch/FY70FGrxs3z8UHOHq5 0wBW433eTvZm90WixBiXEt2v1DgW4Vr3ymfO7Aap/IYyPuE4JzgudAuAl0HKPyNEHWHG1dAb jX1RiCw9gknIDWQOF0B4UAaJctWGVcnZ3A2ULwNGMa1P9ZJlBWf1vcj01aiHMU0yQ7JjJiSp vfm9eM0uSLwRdDrJjyl5ZZqVumjdv2SMNQ8GvYRbEMys3GGDSt9zXgfCSUnPnJfYxjzBHRI6 x44Wfsx8S6hWxepOogCJJ/g67Bk9mY8YV4klWIXDJVOL5jnBC09DbsZG81JaE2QxB8Y7W36Z Mroi9XMxg3s805hQAQUvdG/poU8hN8BWdrnTm/+4eQQp7gDY1ePDmGM6bJC+OHOSnFtR/f+7 0zpKJ10cc7cBygGnl1yR3KjhFyAWUFvP4ZGziKCcpMwXZfe9PGuyA/YOubMphxIn3YsK2wrd faKZYX2GMZCZhMMcvx9IpQrxIJgU+VlwXu/O+Lk10VIPcxPJJwmpdI6HzcS8ZgG6IMcC444X XTuLaP8j2mgcMvYak3ScCykAEQEAAYkCPAQYAQgAJhYhBPqEtpWvK/eaIGQ/8fEEnHKfHGUn BQJbUocAAhsMBQkHhh+AAAoJEPEEnHKfHGUnReMP/RA2UhGQj+G4uBshkRLjpRysabdPqgQB dEBk6wYbio88Wg/2/hgY7UzmDDEwX3sZfQDcrI6+vIobI8uqstZID+WgAAa1JLfChMyVQnSy 0zfWMOABXscc5tGuvFRZvJklTissMFjXUwaREEKp4ZikTvJ/62MCjSdtrUhnPLvoTsHTKRKD ichE+b5A54alwsubTijw12O6N22r5IjZiiSZV0u7dsShyKw+7wCSax9fuBoE43NMYf+dnjMK nerAQYUcZWYMnk+EC8RaqYAxv6XZ2tKx1AkGGktwkQIBwrz9IlDSvJ3LWJ2UIIuLRTdngNgg GIL4zzuUa2F56FqskQIuYMaNETk6LYfalBDQ6TVLAcgCPQxp4k4i/PRsZ3lZ2ZhRHRYciOvm kp+I6EfHwllQpYrWs1thluBGqlJSVJgKl0IOFvKLsQ6KKfqzAwh6FxrO5qajp4viNIgtWoFw O5Bp0jgFTbH2OrMWIRfUdUCH1Djbuo65svhNj7FNsQVYzHDI+Nd1I/LOBoPc3UorRMF2M4JV kUR7skOHWUbPTSNUr7qc14NSMY3PKjGeVGAsBVHBPvmRx/Ss2tW/TpJWpxg4pmquFQSXuaYh Yf4FN8Sxy320pcr+FqN8AhZkYJcNY82OTtR5VEKRC/mYcyq61qXIKqngydn79bJjGxHipxyF FmEC Message-ID: <47d042cb-ccdb-ddcb-cba9-181bb9b51a61@postgresql.org> Date: Wed, 17 Jun 2020 12:15:25 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8IOgHeIHEwc0qN1psKl3BMxe6T2NEPNAt" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8IOgHeIHEwc0qN1psKl3BMxe6T2NEPNAt Content-Type: multipart/mixed; boundary="PHFpGDqsu8vxtAuFD8eLwG2FSeQwMTd2J"; protected-headers="v1" From: "Jonathan S. Katz" To: Magnus Hagander , Andrew Dunstan Cc: Andres Freund , PostgreSQL-development Message-ID: <47d042cb-ccdb-ddcb-cba9-181bb9b51a61@postgresql.org> Subject: Re: language cleanups in code and docs References: <20200615182235.x7lch5n6kcjq4aue@alap3.anarazel.de> <0357f124-8017-1563-6dbf-04ed10d7c041@2ndQuadrant.com> In-Reply-To: --PHFpGDqsu8vxtAuFD8eLwG2FSeQwMTd2J Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/17/20 12:08 PM, Magnus Hagander wrote: >=20 >=20 > On Wed, Jun 17, 2020 at 4:15 PM Andrew Dunstan > = > > wrote: >=20 >=20 > On 6/17/20 6:32 AM, Magnus Hagander wrote: > > > > > > > > > > > > In looking at this I realize we also have exactly one thing refer= red > > to as "blacklist" in our codebase, which is the "enum blacklist" = (and > > then a small internal variable in pgindent). AFAICT, it's not act= ually > > exposed to userspace anywhere, so we could probably make the atta= ched > > change to blocklist at no "cost" (the only thing changed is the n= ame > > of the hash table, and we definitely change things like that in n= ormal > > releases with no specific thought on backwards compat). > > > > >=20 > I'm not sure I like doing s/Black/Block/ here. It reads oddly. Ther= e are > too many other uses of Block in the sources. Forbidden might be a b= etter > substitution, or Banned maybe. BanList is even less characters than= > BlackList. >=20 >=20 > I know, bikeshedding here. >=20 >=20 > I'd be OK with either of those really -- I went with block because it > was the easiest one :) >=20 > Not sure the number of characters is the important part :) Banlist does= > make sense to me for other reasons though -- it's what it is, isn't it?= > It bans those oids from being used in the current session -- I don't > think there's any struggle to "make that sentence work", which means > that seems like the relevant term. >=20 > I do think it's worth doing -- it's a small round of changes, and it > doesn't change anything user-exposed, so the cost for us is basically z= ero.=20 +1. I know post efforts for us to update our language have been well-received, even long after the fact, and given this set has been voiced actively and other fora and, as Magnus states, the cost for us to change it is basically zero, we should just do it. Jonathan --PHFpGDqsu8vxtAuFD8eLwG2FSeQwMTd2J-- --8IOgHeIHEwc0qN1psKl3BMxe6T2NEPNAt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE+oS2la8r95ogZD/x8QSccp8cZScFAl7qQZ0ACgkQ8QSccp8c ZSeq4g/9HCGeN9vLu5ulkc9XSbUCstwweRa4aFc1TX6wzzoYSMYdxkxO4mStwWls t36AMwRtIulO1tSrznbex+eBRiR+lxyOdHKBHNqxfXawKvLRe148YQlc3d7/n+1J KT9KRhkg/9hW3m5IINs7Os0wUqox8ttH8yJmTmLL9cAcF3KGYrPBqy9tUXjvR1Dr jk///YG7XqsdqxEYGKK7yKn+bqd0BBtOHdKsZ4pIkFGxL3rzLiXj+fNYKkieroVB h4nYVQAjlcPkbDe2TAXX5hzbH2WXcscdzT0qaiChFj1ZtPk8G8bsoYTjBXNlz1K0 ovASxyV8M17vI1O9A0kWXDSR54sWDs/NOI4EIwce82q9gbUZIL+1TFBKfAfY1ADl +Izzdfn1WYCtCy0S0JcFg/jHSPtjW8Kj9vaGT70sq4rfs/jqG2ooXv1fNwJbv5pC PlOa8xJYIvNsKUnlpFlc0f1KN748m5IYkLZXFwhlZMhyZon2sr4ALXJIACxz/2zY 319wQrp0fgHIPmayNI7Bl8lAeuW4WRMjrHGipokgKZ3WAGzHJqpjAIy15RXiF57E G7lq3OervbvDqWkfHHNTqq314Rq1ItD+t5LVqYsnwOlvFqedfn10rIhZ7DMPQZIm qQEDMLUHyhgyyanNYORUaOdKCHS1iDRLJumlZLF/L8pVCrImkbA= =V5G3 -----END PGP SIGNATURE----- --8IOgHeIHEwc0qN1psKl3BMxe6T2NEPNAt--