Message-ID: <47e1b4f72fe732c5ae85c6cf2c085b4e99a10120.camel@j-davis.com>
Subject: Re: Change initdb default to the builtin collation provider
From: Jeff Davis <pgsql@j-davis.com>
To: pgsql-hackers@postgresql.org
Date: Fri, 31 Oct 2025 14:30:19 -0700
In-Reply-To: <e4ac16908dad3eddd3ed73c4862591375a3f0539.camel@j-davis.com>
References: <e4ac16908dad3eddd3ed73c4862591375a3f0539.camel@j-davis.com>
Content-Type: multipart/mixed; boundary="=-ggvP/RBiEsz2petvrijI"
User-Agent: Evolution 3.52.3-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/47e1b4f72fe732c5ae85c6cf2c085b4e99a10120.camel%40j-davis.com>
Precedence: bulk

--=-ggvP/RBiEsz2petvrijI
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2025-10-10 at 17:48 -0700, Jeff Davis wrote:
> -------
> Summary
> -------
>=20
> The libc collation provider is a bad default[1]. The builtin
> collation
> provider is a good default, so let's use that.

The attached patches implement a more modest proposal which does not
conflict with Peter's objection about the display order:

0001: If the encoding is unspecified, and cannot be determined from the
locale (i.e. the locale is C), then use UTF-8 rather than SQL_ASCII.

0002: If the provider is unspecified, and the locale is C or C.UTF-8,
then use the builtin provider.

Motivation:

* UTF-8 seems safer than SQL_ASCII when the locale is compatible with
either.

* Whether the "C" locale uses the builtin provider or the libc provider
is mostly about the catalog representation, because the implementation
is the same. I don't have a strong motivation for this change, it just
clarifies that libc is not actually being used when the locale is "C".

* I think most users of the "C.UTF-8" locale would be better off with
the builtin provider, which benefits from important optimizations.

Note:

This would mean that "initdb --no-locale" would select UTF-8 and the
builtin provider with locale "C", whereas previously it would have
selected SQL_ASCII and the libc provider (though it didn't ever really
use libc internally). I'm not sure if others want this behavior or if
it would be surprising.

Regards,
	Jeff Davis


--=-ggvP/RBiEsz2petvrijI
Content-Disposition: attachment;
	filename="v1-0001-initdb-prefer-UTF-8-encoding-over-SQL_ASCII.patch"
Content-Type: text/x-patch;
	name="v1-0001-initdb-prefer-UTF-8-encoding-over-SQL_ASCII.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSA5YzhjZjU4YzU0MTQ2MmE2YWVmNDNmZWQwZGRlYTFlOWYxNjMzOTYwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBG
cmksIDMxIE9jdCAyMDI1IDEzOjM2OjQ2IC0wNzAwClN1YmplY3Q6IFtQQVRDSCB2MSAxLzJdIGlu
aXRkYjogcHJlZmVyIFVURi04IGVuY29kaW5nIG92ZXIgU1FMX0FTQ0lJLgoKVGhpcyB3YXMgYWxy
ZWFkeSB0cnVlIGZvciB0aGUgSUNVIGxvY2FsZSBwcm92aWRlciwgbWFrZSBpdCB0cnVlIGZvcgp0
aGUgb3RoZXJzLgotLS0KIHNyYy9iaW4vaW5pdGRiL2luaXRkYi5jIHwgNiArKystLS0KIDEgZmls
ZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv
c3JjL2Jpbi9pbml0ZGIvaW5pdGRiLmMgYi9zcmMvYmluL2luaXRkYi9pbml0ZGIuYwppbmRleCA5
MmZlMmY1MzFmNy4uYWE3ZmM1YTY2MzYgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vaW5pdGRiL2luaXRk
Yi5jCisrKyBiL3NyYy9iaW4vaW5pdGRiL2luaXRkYi5jCkBAIC0yNzE4LDEwICsyNzE4LDEwIEBA
IHNldHVwX2xvY2FsZV9lbmNvZGluZyh2b2lkKQogCQljdHlwZV9lbmMgPSBwZ19nZXRfZW5jb2Rp
bmdfZnJvbV9sb2NhbGUobGNfY3R5cGUsIHRydWUpOwogCiAJCS8qCi0JCSAqIElmIGN0eXBlX2Vu
Yz1TUUxfQVNDSUksIGl0J3MgY29tcGF0aWJsZSB3aXRoIGFueSBlbmNvZGluZy4gSUNVIGRvZXMK
LQkJICogbm90IHN1cHBvcnQgU1FMX0FTQ0lJLCBzbyBzZWxlY3QgVVRGLTggaW5zdGVhZC4KKwkJ
ICogSWYgY3R5cGVfZW5jPVNRTF9BU0NJSSwgaXQncyBjb21wYXRpYmxlIHdpdGggYW55IGVuY29k
aW5nLiBQcmVmZXIKKwkJICogVVRGLTguCiAJCSAqLwotCQlpZiAobG9jYWxlX3Byb3ZpZGVyID09
IENPTExQUk9WSURFUl9JQ1UgJiYgY3R5cGVfZW5jID09IFBHX1NRTF9BU0NJSSkKKwkJaWYgKGN0
eXBlX2VuYyA9PSBQR19TUUxfQVNDSUkpCiAJCQljdHlwZV9lbmMgPSBQR19VVEY4OwogCiAJCWlm
IChjdHlwZV9lbmMgPT0gLTEpCi0tIAoyLjQzLjAKCg==


--=-ggvP/RBiEsz2petvrijI
Content-Disposition: attachment;
	filename*0=v1-0002-initdb-if-locale-is-C-or-C.UTF-8-use-builtin-prov.pat;
	filename*1=ch
Content-Type: text/x-patch;
	name="v1-0002-initdb-if-locale-is-C-or-C.UTF-8-use-builtin-prov.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSA4YjE2NTlmYWI1MDM5NmVhZWFjYWIwNDJhZWFlZjhkZjI0MWFmNDY3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBG
cmksIDMxIE9jdCAyMDI1IDE0OjA1OjEwIC0wNzAwClN1YmplY3Q6IFtQQVRDSCB2MSAyLzJdIGlu
aXRkYjogaWYgbG9jYWxlIGlzIEMgb3IgQy5VVEYtOCwgdXNlIGJ1aWx0aW4KIHByb3ZpZGVyLgoK
SWYgdGhlIHByb3ZpZGVyIGlzIHVuc3BlY2lmaWVkLCB1c2UgdGhlIGJ1aWx0aW4gcHJvdmlkZXIg
QyBvcgpDLlVURi04LiBJZiB0aGUgcHJvdmlkZXIgaXMgc3BlY2lmaWVkLCB0aGVuIGRvIG5vdCBv
dmVycmlkZSBpdC4KClRoZSBDIGxvY2FsZSBoYXMgYWx3YXlzIGJlZW4sIGVmZmVjdGl2ZWx5LCB0
aGUgYnVpbHRpbiBwcm92aWRlciwgaW4KdGhlIHNlbnNlIHRoYXQgaXQgdXNlcyBidWlsdC1pbiBs
b2dpYyByYXRoZXIgdGhhbiBzdHJjb2xsKCksIGV0Yy4gVGhlCmNoYW5nZSBoZXJlIGlzIG1vc3Rs
eSBhYm91dCB0aGUgY2F0YWxvZyByZXByZXNlbnRhdGlvbi4KClRoZSBDLlVURi04IGxvY2FsZSBo
YXMgdXNlZCBsaWJjLCBidXQgYnkgZG9pbmcgc28sIGNvbGxhdGlvbiBkb2Vzbid0CmJlbmVmaXQg
ZnJvbSBpbXBvcnRhbnQgcGVyZm9ybWFuY2Ugb3B0aW1pemF0aW9ucy4gTm93IHRoYXQgd2UgaGF2
ZSBhCmJ1aWx0aW4gIkMuVVRGLTgiIGNvbGxhdGlvbiB3aGljaCBkb2VzIGJlbmVmaXQgZnJvbSB0
aG9zZQpvcHRpbWl6YXRpb25zLCB1c2UgdGhhdC4KLS0tCiBzcmMvYmluL2luaXRkYi9pbml0ZGIu
YyB8IDI1ICsrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNl
cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9pbml0ZGIvaW5pdGRiLmMgYi9zcmMvYmlu
L2luaXRkYi9pbml0ZGIuYwppbmRleCBhYTdmYzVhNjYzNi4uODQ5MzFmMTQ1ZjQgMTAwNjQ0Ci0t
LSBhL3NyYy9iaW4vaW5pdGRiL2luaXRkYi5jCisrKyBiL3NyYy9iaW4vaW5pdGRiL2luaXRkYi5j
CkBAIC0xNDUsNiArMTQ1LDcgQEAgc3RhdGljIGNoYXIgKmxjX251bWVyaWMgPSBOVUxMOwogc3Rh
dGljIGNoYXIgKmxjX3RpbWUgPSBOVUxMOwogc3RhdGljIGNoYXIgKmxjX21lc3NhZ2VzID0gTlVM
TDsKIHN0YXRpYyBjaGFyIGxvY2FsZV9wcm92aWRlciA9IENPTExQUk9WSURFUl9MSUJDOworc3Rh
dGljIGJvb2wgbG9jYWxlX3Byb3ZpZGVyX3NwZWNpZmllZCA9IGZhbHNlOwogc3RhdGljIGJvb2wg
YnVpbHRpbl9sb2NhbGVfc3BlY2lmaWVkID0gZmFsc2U7CiBzdGF0aWMgY2hhciAqZGF0bG9jYWxl
ID0gTlVMTDsKIHN0YXRpYyBib29sIGljdV9sb2NhbGVfc3BlY2lmaWVkID0gZmFsc2U7CkBAIC0y
NDY1LDYgKzI0NjYsMjggQEAgc2V0bG9jYWxlcyh2b2lkKQogCWxjX21lc3NhZ2VzID0gY2Fub25u
YW1lOwogI2VuZGlmCiAKKwkvKgorCSAqIElmIHRoZSBsb2NhbGUgaXMgQyBvciBDLlVURi04LCBh
bmQgbm8gcHJvdmlkZXIgd2FzIHNwZWNpZmllZCwgdXNlIHRoZQorCSAqIGJ1aWx0aW4gcHJvdmlk
ZXIgcmF0aGVyIHRoYW4gbGliYy4KKwkgKi8KKwlpZiAoIWxvY2FsZV9wcm92aWRlcl9zcGVjaWZp
ZWQgJiYgbG9jYWxlX3Byb3ZpZGVyID09IENPTExQUk9WSURFUl9MSUJDKQorCXsKKwkJaWYgKHN0
cmNtcChsY19jdHlwZSwgbGNfY29sbGF0ZSkgPT0gMCkKKwkJeworCQkJaWYgKHN0cmNtcChsY19j
dHlwZSwgIkMiKSA9PSAwKQorCQkJeworCQkJCWxvY2FsZV9wcm92aWRlciA9IENPTExQUk9WSURF
Ul9CVUlMVElOOworCQkJCWRhdGxvY2FsZSA9ICJDIjsKKwkJCX0KKwkJCWVsc2UgaWYgKHN0cmNt
cChsY19jdHlwZSwgIkMuVVRGLTgiKSA9PSAwIHx8CisJCQkJCSBzdHJjbXAobGNfY3R5cGUsICJD
LlVURjgiKSA9PSAwKQorCQkJeworCQkJCWxvY2FsZV9wcm92aWRlciA9IENPTExQUk9WSURFUl9C
VUlMVElOOworCQkJCWRhdGxvY2FsZSA9ICJDLlVURi04IjsKKwkJCX0KKwkJfQorCX0KKwogCWlm
IChsb2NhbGVfcHJvdmlkZXIgIT0gQ09MTFBST1ZJREVSX0xJQkMgJiYgZGF0bG9jYWxlID09IE5V
TEwpCiAJCXBnX2ZhdGFsKCJsb2NhbGUgbXVzdCBiZSBzcGVjaWZpZWQgaWYgcHJvdmlkZXIgaXMg
JXMiLAogCQkJCSBjb2xscHJvdmlkZXJfbmFtZShsb2NhbGVfcHJvdmlkZXIpKTsKQEAgLTMzNjIs
NiArMzM4NSw4IEBAIG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJCQkJCQkJCQkgIi1j
IGRlYnVnX2Rpc2NhcmRfY2FjaGVzPTEiKTsKIAkJCQlicmVhazsKIAkJCWNhc2UgMTU6CisJCQkJ
bG9jYWxlX3Byb3ZpZGVyX3NwZWNpZmllZCA9IHRydWU7CisKIAkJCQlpZiAoc3RyY21wKG9wdGFy
ZywgImJ1aWx0aW4iKSA9PSAwKQogCQkJCQlsb2NhbGVfcHJvdmlkZXIgPSBDT0xMUFJPVklERVJf
QlVJTFRJTjsKIAkJCQllbHNlIGlmIChzdHJjbXAob3B0YXJnLCAiaWN1IikgPT0gMCkKLS0gCjIu
NDMuMAoK


--=-ggvP/RBiEsz2petvrijI--